Merge pull request #56 from bizzkoot/feat/centralized-permission-notifications

feat: Add Centralized Permission Notification System
This commit is contained in:
Shantur Rathore
2026-01-08 23:19:29 +00:00
committed by GitHub
8 changed files with 631 additions and 52 deletions

View File

@@ -76,6 +76,29 @@ xattr -dr com.apple.quarantine /Applications/CodeNomad.app
After removing the quarantine attribute, launch the app normally. On Intel Macs you may also need to approve CodeNomad from **System Settings → Privacy & Security** the first time you run it.
### Linux (Wayland + NVIDIA): Tauri AppImage closes immediately
On some Wayland compositor + NVIDIA driver setups, WebKitGTK can fail to initialize its DMA-BUF/GBM path and the Tauri build may exit right away.
Try running with one of these environment variables:
```bash
# Most reliable workaround (can reduce rendering performance)
WEBKIT_DISABLE_DMABUF_RENDERER=1 codenomad
# Alternative for some Wayland setups
__NV_DISABLE_EXPLICIT_SYNC=1 codenomad
```
If you're running the Tauri AppImage and want the workaround applied every time, create a tiny wrapper script on your `PATH`:
```bash
#!/bin/bash
export WEBKIT_DISABLE_DMABUF_RENDERER=1
exec ~/.local/share/bauh/appimage/installed/codenomad/CodeNomad-Tauri-0.4.0-linux-x64.AppImage "$@"
```
Upstream tracking: https://github.com/tauri-apps/tauri/issues/10702
## Architecture & Development
CodeNomad is a monorepo split into specialized packages. If you want to contribute or build from source, check out the individual package documentation:

View File

@@ -49,6 +49,8 @@ import InstanceServiceStatus from "../instance-service-status"
import AgentSelector from "../agent-selector"
import ModelSelector from "../model-selector"
import CommandPalette from "../command-palette"
import PermissionNotificationBanner from "../permission-notification-banner"
import PermissionApprovalModal from "../permission-approval-modal"
import Kbd from "../kbd"
import { TodoListView } from "../tool-call/renderers/todo"
import ContextUsagePanel from "../session/context-usage-panel"
@@ -140,6 +142,7 @@ const InstanceShell2: Component<InstanceShellProps> = (props) => {
])
const [selectedBackgroundProcess, setSelectedBackgroundProcess] = createSignal<BackgroundProcess | null>(null)
const [showBackgroundOutput, setShowBackgroundOutput] = createSignal(false)
const [permissionModalOpen, setPermissionModalOpen] = createSignal(false)
const messageStore = createMemo(() => messageStoreBus.getOrCreate(props.instance.id))
@@ -651,7 +654,7 @@ const InstanceShell2: Component<InstanceShellProps> = (props) => {
})
type DrawerViewState = "pinned" | "floating-open" | "floating-closed"
const leftDrawerState = createMemo<DrawerViewState>(() => {
if (leftPinned()) return "pinned"
@@ -692,7 +695,7 @@ const InstanceShell2: Component<InstanceShellProps> = (props) => {
const pinLeftDrawer = () => {
const pinLeftDrawer = () => {
blurIfInside(leftDrawerContentEl())
batch(() => {
setLeftPinned(true)
@@ -811,18 +814,18 @@ const InstanceShell2: Component<InstanceShellProps> = (props) => {
</Show>
</div>
</div>
<div class="flex items-center gap-2">
<Show when={!isPhoneLayout()}>
<IconButton
size="small"
color="inherit"
aria-label={leftPinned() ? "Unpin left drawer" : "Pin left drawer"}
onClick={() => (leftPinned() ? unpinLeftDrawer() : pinLeftDrawer())}
>
{leftPinned() ? <PushPinIcon fontSize="small" /> : <PushPinOutlinedIcon fontSize="small" />}
</IconButton>
</Show>
</div>
<div class="flex items-center gap-2">
<Show when={!isPhoneLayout()}>
<IconButton
size="small"
color="inherit"
aria-label={leftPinned() ? "Unpin left drawer" : "Pin left drawer"}
onClick={() => (leftPinned() ? unpinLeftDrawer() : pinLeftDrawer())}
>
{leftPinned() ? <PushPinIcon fontSize="small" /> : <PushPinOutlinedIcon fontSize="small" />}
</IconButton>
</Show>
</div>
</div>
@@ -1219,6 +1222,10 @@ const InstanceShell2: Component<InstanceShellProps> = (props) => {
</IconButton>
<div class="flex flex-wrap items-center gap-1 justify-center">
<PermissionNotificationBanner
instanceId={props.instance.id}
onClick={() => setPermissionModalOpen(true)}
/>
<button
type="button"
class="connection-status-button px-2 py-0.5 text-xs"
@@ -1237,6 +1244,8 @@ const InstanceShell2: Component<InstanceShellProps> = (props) => {
>
<span class="status-dot" />
</span>
</div>
<IconButton
@@ -1265,46 +1274,52 @@ const InstanceShell2: Component<InstanceShellProps> = (props) => {
</div>
}
>
<div class="session-toolbar-left flex items-center gap-3 min-w-0">
<IconButton
ref={setLeftToggleButtonEl}
color="inherit"
onClick={handleLeftAppBarButtonClick}
aria-label={leftAppBarButtonLabel()}
size="small"
aria-expanded={leftDrawerState() !== "floating-closed"}
disabled={leftDrawerState() === "pinned"}
>
{leftAppBarButtonIcon()}
</IconButton>
<div class="session-toolbar-left flex items-center gap-3 min-w-0">
<IconButton
ref={setLeftToggleButtonEl}
color="inherit"
onClick={handleLeftAppBarButtonClick}
aria-label={leftAppBarButtonLabel()}
size="small"
aria-expanded={leftDrawerState() !== "floating-closed"}
disabled={leftDrawerState() === "pinned"}
>
{leftAppBarButtonIcon()}
</IconButton>
<Show when={!showingInfoView()}>
<div class="inline-flex items-center gap-1 rounded-full border border-base px-2 py-0.5 text-xs text-primary">
<span class="uppercase text-[10px] tracking-wide text-primary/70">Used</span>
<span class="font-semibold text-primary">{formattedUsedTokens()}</span>
</div>
<div class="inline-flex items-center gap-1 rounded-full border border-base px-2 py-0.5 text-xs text-primary">
<span class="uppercase text-[10px] tracking-wide text-primary/70">Avail</span>
<span class="font-semibold text-primary">{formattedAvailableTokens()}</span>
</div>
</Show>
</div>
<Show when={!showingInfoView()}>
<div class="inline-flex items-center gap-1 rounded-full border border-base px-2 py-0.5 text-xs text-primary">
<span class="uppercase text-[10px] tracking-wide text-primary/70">Used</span>
<span class="font-semibold text-primary">{formattedUsedTokens()}</span>
</div>
<div class="inline-flex items-center gap-1 rounded-full border border-base px-2 py-0.5 text-xs text-primary">
<span class="uppercase text-[10px] tracking-wide text-primary/70">Avail</span>
<span class="font-semibold text-primary">{formattedAvailableTokens()}</span>
</div>
</Show>
</div>
<div class="session-toolbar-center flex-1 flex items-center justify-center gap-2 min-w-[160px]">
<button
type="button"
class="connection-status-button px-2 py-0.5 text-xs"
onClick={handleCommandPaletteClick}
aria-label="Open command palette"
style={{ flex: "0 0 auto", width: "auto" }}
>
Command Palette
</button>
<span class="connection-status-shortcut-hint">
<Kbd shortcut="cmd+shift+p" />
</span>
</div>
<div class="session-toolbar-center flex-1 flex items-center justify-center gap-2 min-w-[160px]">
<PermissionNotificationBanner
instanceId={props.instance.id}
onClick={() => setPermissionModalOpen(true)}
/>
<button
type="button"
class="connection-status-button px-2 py-0.5 text-xs"
onClick={handleCommandPaletteClick}
aria-label="Open command palette"
style={{ flex: "0 0 auto", width: "auto" }}
>
Command Palette
</button>
<span class="connection-status-shortcut-hint">
<Kbd shortcut="cmd+shift+p" />
</span>
</div>
<div class="session-toolbar-right flex items-center gap-3">
@@ -1426,6 +1441,12 @@ const InstanceShell2: Component<InstanceShellProps> = (props) => {
process={selectedBackgroundProcess()}
onClose={closeBackgroundOutput}
/>
<PermissionApprovalModal
instanceId={props.instance.id}
isOpen={permissionModalOpen()}
onClose={() => setPermissionModalOpen(false)}
/>
</>
)
}

View File

@@ -0,0 +1,251 @@
import { For, Show, createMemo, createSignal, createEffect, onCleanup, type Component } from "solid-js"
import type { PermissionRequestLike } from "../types/permission"
import { getPermissionCallId, getPermissionDisplayTitle, getPermissionKind, getPermissionMessageId, getPermissionSessionId } from "../types/permission"
import { activePermissionId, getPermissionQueue } from "../stores/instances"
import { loadMessages, setActiveSession } from "../stores/sessions"
import { messageStoreBus } from "../stores/message-v2/bus"
import ToolCall from "./tool-call"
interface PermissionApprovalModalProps {
instanceId: string
isOpen: boolean
onClose: () => void
}
type ResolvedToolCall = {
messageId: string
sessionId: string
toolPart: Extract<import("../types/message").ClientPart, { type: "tool" }>
messageVersion: number
partVersion: number
}
function resolveToolCallFromPermission(
instanceId: string,
permission: PermissionRequestLike,
): ResolvedToolCall | null {
const sessionId = getPermissionSessionId(permission)
const messageId = getPermissionMessageId(permission)
if (!sessionId || !messageId) return null
const store = messageStoreBus.getInstance(instanceId)
if (!store) return null
const record = store.getMessage(messageId)
if (!record) return null
const metadata = ((permission as any).metadata || {}) as Record<string, unknown>
const directPartId =
(permission as any).partID ??
(permission as any).partId ??
(metadata as any).partID ??
(metadata as any).partId ??
undefined
const callId = getPermissionCallId(permission)
const findToolPart = (partId: string) => {
const partRecord = record.parts?.[partId]
const part = partRecord?.data
if (!part || part.type !== "tool") return null
return {
toolPart: part as ResolvedToolCall["toolPart"],
partVersion: partRecord.revision ?? 0,
}
}
if (typeof directPartId === "string" && directPartId.length > 0) {
const resolved = findToolPart(directPartId)
if (resolved) {
return {
messageId,
sessionId,
toolPart: resolved.toolPart,
messageVersion: record.revision,
partVersion: resolved.partVersion,
}
}
}
if (callId) {
for (const partId of record.partIds) {
const partRecord = record.parts?.[partId]
const part = partRecord?.data as any
if (!part || part.type !== "tool") continue
const partCallId = part.callID ?? part.callId ?? part.toolCallID ?? part.toolCallId ?? undefined
if (partCallId === callId && typeof part.id === "string" && part.id.length > 0) {
return {
messageId,
sessionId,
toolPart: part as ResolvedToolCall["toolPart"],
messageVersion: record.revision,
partVersion: partRecord.revision ?? 0,
}
}
}
}
return null
}
const PermissionApprovalModal: Component<PermissionApprovalModalProps> = (props) => {
const [loadingSession, setLoadingSession] = createSignal<string | null>(null)
const queue = createMemo(() => getPermissionQueue(props.instanceId))
const activePermId = createMemo(() => activePermissionId().get(props.instanceId) ?? null)
const orderedQueue = createMemo(() => {
const current = queue()
const activeId = activePermId()
if (!activeId) return current
const index = current.findIndex((entry) => entry.id === activeId)
if (index <= 0) return current
const active = current[index]
if (!active) return current
return [active, ...current.slice(0, index), ...current.slice(index + 1)]
})
const hasPermissions = createMemo(() => queue().length > 0)
const closeOnEscape = (event: KeyboardEvent) => {
if (event.key === "Escape") {
event.preventDefault()
props.onClose()
}
}
createEffect(() => {
if (!props.isOpen) return
document.addEventListener("keydown", closeOnEscape)
onCleanup(() => document.removeEventListener("keydown", closeOnEscape))
})
createEffect(() => {
if (!props.isOpen) return
if (queue().length === 0) {
props.onClose()
}
})
function handleBackdropClick(event: MouseEvent) {
if (event.target === event.currentTarget) {
props.onClose()
}
}
async function handleLoadSession(sessionId: string) {
if (!sessionId) return
setLoadingSession(sessionId)
try {
await loadMessages(props.instanceId, sessionId)
} finally {
setLoadingSession((current) => (current === sessionId ? null : current))
}
}
function handleGoToSession(sessionId: string) {
if (!sessionId) return
setActiveSession(props.instanceId, sessionId)
props.onClose()
}
return (
<Show when={props.isOpen}>
<div class="permission-center-modal-backdrop" onClick={handleBackdropClick}>
<div class="permission-center-modal" role="dialog" aria-modal="true" aria-labelledby="permission-center-title">
<div class="permission-center-modal-header">
<div class="permission-center-modal-title-row">
<h2 id="permission-center-title" class="permission-center-modal-title">
Permissions
</h2>
<Show when={queue().length > 0}>
<span class="permission-center-modal-count">{queue().length}</span>
</Show>
</div>
<button type="button" class="permission-center-modal-close" onClick={props.onClose} aria-label="Close">
</button>
</div>
<div class="permission-center-modal-body">
<Show when={hasPermissions()} fallback={<div class="permission-center-empty">No pending permissions.</div>}>
<div class="permission-center-list" role="list">
<For each={orderedQueue()}>
{(permission) => {
const sessionId = getPermissionSessionId(permission) || ""
const isActive = () => permission.id === activePermId()
const resolved = createMemo(() => resolveToolCallFromPermission(props.instanceId, permission))
const showFallback = () => !resolved()
return (
<div
class={`permission-center-item${isActive() ? " permission-center-item-active" : ""}`}
role="listitem"
>
<div class="permission-center-item-header">
<div class="permission-center-item-heading">
<span class="permission-center-item-kind">{getPermissionKind(permission)}</span>
<Show when={isActive()}>
<span class="permission-center-item-chip">Active</span>
</Show>
</div>
<div class="permission-center-item-actions">
<button
type="button"
class="permission-center-item-action"
onClick={() => handleGoToSession(sessionId)}
>
Go to Session
</button>
<Show when={showFallback()}>
<button
type="button"
class="permission-center-item-action"
disabled={loadingSession() === sessionId}
onClick={() => handleLoadSession(sessionId)}
>
{loadingSession() === sessionId ? "Loading…" : "Load Session"}
</button>
</Show>
</div>
</div>
<Show
when={resolved()}
fallback={
<div class="permission-center-fallback">
<div class="permission-center-fallback-title">
<code>{getPermissionDisplayTitle(permission)}</code>
</div>
<div class="permission-center-fallback-hint">Load session for more information.</div>
</div>
}
>
{(data) => (
<ToolCall
toolCall={data().toolPart}
toolCallId={data().toolPart.id}
messageId={data().messageId}
messageVersion={data().messageVersion}
partVersion={data().partVersion}
instanceId={props.instanceId}
sessionId={data().sessionId}
/>
)}
</Show>
</div>
)
}}
</For>
</div>
</Show>
</div>
</div>
</div>
</Show>
)
}
export default PermissionApprovalModal

View File

@@ -0,0 +1,36 @@
import { Show, createMemo, type Component } from "solid-js"
import { ShieldAlert } from "lucide-solid"
import { getPermissionQueueLength } from "../stores/instances"
interface PermissionNotificationBannerProps {
instanceId: string
onClick: () => void
}
const PermissionNotificationBanner: Component<PermissionNotificationBannerProps> = (props) => {
const queueLength = createMemo(() => getPermissionQueueLength(props.instanceId))
const hasPermissions = createMemo(() => queueLength() > 0)
const label = createMemo(() => {
const count = queueLength()
return `${count} permission${count === 1 ? "" : "s"} pending approval`
})
return (
<Show when={hasPermissions()}>
<button
type="button"
class="permission-center-trigger"
onClick={props.onClick}
aria-label={label()}
title={label()}
>
<ShieldAlert class="permission-center-icon" aria-hidden="true" />
<span class="permission-center-count" aria-hidden="true">
{queueLength() > 9 ? "9+" : queueLength()}
</span>
</button>
</Show>
)
}
export default PermissionNotificationBanner

View File

@@ -7,6 +7,7 @@ import { resolvePastedPlaceholders } from "../lib/prompt-placeholders"
import { createFileAttachment, createTextAttachment, createAgentAttachment } from "../types/attachment"
import type { Attachment } from "../types/attachment"
import type { Agent } from "../types/session"
import type { Command as SDKCommand } from "@opencode-ai/sdk/v2"
import Kbd from "./kbd"
import { getActiveInstance } from "../stores/instances"
import { agents, getSessionDraftPrompt, setSessionDraftPrompt, clearSessionDraftPrompt, executeCustomCommand } from "../stores/sessions"
@@ -767,7 +768,7 @@ export default function PromptInput(props: PromptInputProps) {
type: "file"
file: { path: string; relativePath?: string; isGitFile: boolean; isDirectory?: boolean }
}
| { type: "command"; command: { name: string; description?: string } },
| { type: "command"; command: SDKCommand },
) {
if (item.type === "command") {
const name = item.command.name

View File

@@ -562,6 +562,14 @@ function clearPermissionQueue(instanceId: string): void {
function setActivePermissionIdForInstance(instanceId: string, permissionId: string): void {
setActivePermissionId((prev) => {
const next = new Map(prev)
next.set(instanceId, permissionId)
return next
})
}
async function sendPermissionResponse(
instanceId: string,
sessionId: string,
@@ -656,6 +664,7 @@ export {
removePermissionFromQueue,
clearPermissionQueue,
sendPermissionResponse,
setActivePermissionIdForInstance,
disconnectedInstance,
acknowledgeDisconnectedInstance,
fetchLspStatus,

View File

@@ -0,0 +1,237 @@
/* Central permission UI (toolbar + modal).
Kept intentionally small; reuse existing tokens. */
.permission-center-trigger {
display: inline-flex;
align-items: center;
gap: 0.25rem;
padding: 0.25rem 0.5rem;
border-radius: 9999px;
border: 1px solid var(--session-status-permission-fg);
background-color: var(--session-status-permission-bg);
color: var(--session-status-permission-fg);
font-size: 0.75rem;
font-weight: var(--font-weight-semibold);
cursor: pointer;
transition: background-color 0.15s ease, border-color 0.15s ease, transform 0.15s ease;
}
.permission-center-trigger:hover,
.permission-center-trigger:focus-visible {
outline: none;
background-color: color-mix(in srgb, var(--session-status-permission-bg) 70%, var(--surface-hover));
transform: translateY(-1px);
}
.permission-center-icon {
width: 1rem;
height: 1rem;
}
.permission-center-count {
line-height: 1;
}
.permission-center-modal-backdrop {
position: fixed;
inset: 0;
background: color-mix(in srgb, var(--text-inverted) 55%, transparent);
backdrop-filter: blur(4px);
display: flex;
align-items: center;
justify-content: center;
z-index: 9999;
padding: var(--space-lg);
}
.permission-center-modal {
width: min(900px, 100%);
max-height: 90vh;
display: flex;
flex-direction: column;
border-radius: var(--radius-xl);
border: 1px solid var(--border-base);
background: var(--surface-base);
box-shadow: var(--panel-shadow, 0 12px 32px rgba(0, 0, 0, 0.25));
overflow: hidden;
}
.permission-center-modal-header {
display: flex;
align-items: center;
justify-content: space-between;
gap: var(--space-md);
padding: var(--space-md);
border-bottom: 1px solid var(--border-base);
}
.permission-center-modal-title-row {
display: flex;
align-items: center;
gap: var(--space-sm);
min-width: 0;
}
.permission-center-modal-title {
font-size: var(--font-size-lg);
font-weight: var(--font-weight-semibold);
color: var(--text-primary);
margin: 0;
}
.permission-center-modal-count {
display: inline-flex;
align-items: center;
justify-content: center;
min-width: 1.5rem;
height: 1.5rem;
padding: 0 0.4rem;
border-radius: 9999px;
background: var(--session-status-permission-bg);
color: var(--session-status-permission-fg);
border: 1px solid var(--session-status-permission-fg);
font-size: var(--font-size-xs);
font-weight: var(--font-weight-semibold);
}
.permission-center-modal-close {
display: inline-flex;
align-items: center;
justify-content: center;
width: 2rem;
height: 2rem;
border-radius: var(--radius-sm);
border: 1px solid var(--border-base);
background: var(--surface-secondary);
color: var(--text-primary);
cursor: pointer;
}
.permission-center-modal-close:hover {
background: var(--surface-hover);
}
.permission-center-modal-body {
flex: 1;
min-height: 0;
overflow: auto;
padding: var(--space-md);
}
.permission-center-empty {
color: var(--text-secondary);
padding: var(--space-lg);
text-align: center;
}
.permission-center-list {
display: flex;
flex-direction: column;
gap: var(--space-md);
}
.permission-center-item {
border: 1px solid var(--border-base);
border-radius: var(--radius-lg);
background: var(--surface-secondary);
overflow: hidden;
}
.permission-center-item-active {
border-color: var(--session-status-permission-fg);
}
.permission-center-item-header {
display: flex;
align-items: center;
justify-content: space-between;
gap: var(--space-md);
padding: var(--space-sm) var(--space-md);
border-bottom: 1px solid var(--border-base);
background: var(--surface-base);
}
.permission-center-item-heading {
display: flex;
align-items: center;
gap: var(--space-sm);
}
.permission-center-item-kind {
font-size: var(--font-size-xs);
letter-spacing: 0.05em;
text-transform: uppercase;
color: var(--text-secondary);
font-weight: var(--font-weight-semibold);
}
.permission-center-item-chip {
font-size: var(--font-size-xs);
font-weight: var(--font-weight-semibold);
padding: 0.1rem 0.4rem;
border-radius: 9999px;
border: 1px solid var(--session-status-permission-fg);
background: var(--session-status-permission-bg);
color: var(--session-status-permission-fg);
}
.permission-center-item-actions {
display: inline-flex;
align-items: center;
gap: var(--space-sm);
}
.permission-center-item-action {
padding: 0.25rem 0.5rem;
border-radius: var(--radius-sm);
border: 1px solid var(--border-base);
background: var(--surface-secondary);
color: var(--text-primary);
font-size: var(--font-size-xs);
cursor: pointer;
}
.permission-center-item-action:hover {
background: var(--surface-hover);
}
.permission-center-item-action:disabled {
opacity: 0.6;
cursor: not-allowed;
}
.permission-center-fallback {
padding: var(--space-md);
}
.permission-center-fallback-title code {
font-family: var(--font-family-mono);
font-size: var(--font-size-sm);
color: var(--text-primary);
}
.permission-center-fallback-hint {
margin-top: var(--space-sm);
color: var(--text-secondary);
font-size: var(--font-size-sm);
}
/* Remove border from tool-call when inside permission items to avoid double borders */
.permission-center-item .tool-call {
border: none;
border-radius: 0;
margin: 0;
}
@media (max-width: 720px) {
.permission-center-modal-backdrop {
padding: 0;
}
.permission-center-modal {
width: 100vw;
height: 100vh;
max-height: none;
border-radius: 0;
}
}

View File

@@ -6,3 +6,4 @@
@import "./components/env-vars.css";
@import "./components/directory-browser.css";
@import "./components/remote-access.css";
@import "./components/permission-notification.css";