fix(i18n): tighten RTL locale follow-up

This commit is contained in:
Shantur Rathore
2026-03-24 21:03:18 +00:00
parent 46150cda5e
commit afc554ef98
4 changed files with 4 additions and 11 deletions

View File

@@ -342,7 +342,7 @@ const FolderSelectionView: Component<FolderSelectionViewProps> = (props) => {
class="w-full max-w-5xl h-full px-4 sm:px-8 pb-2 flex flex-col overflow-hidden" class="w-full max-w-5xl h-full px-4 sm:px-8 pb-2 flex flex-col overflow-hidden"
aria-busy={isLoading() ? "true" : "false"} aria-busy={isLoading() ? "true" : "false"}
> >
<div class="absolute top-4 left-6"> <div class="absolute top-4" style="inset-inline-start: 1.5rem;">
<Select<LanguageOption> <Select<LanguageOption>
value={selectedLanguageOption()} value={selectedLanguageOption()}
onChange={(value) => { onChange={(value) => {
@@ -386,7 +386,7 @@ const FolderSelectionView: Component<FolderSelectionViewProps> = (props) => {
</Select.Portal> </Select.Portal>
</Select> </Select>
</div> </div>
<div class="absolute top-4 right-6 flex items-center gap-2"> <div class="absolute top-4 flex items-center gap-2" style="inset-inline-end: 1.5rem;">
<button <button
type="button" type="button"
class="selector-button selector-button-secondary w-auto p-2 inline-flex items-center justify-center" class="selector-button selector-button-secondary w-auto p-2 inline-flex items-center justify-center"

View File

@@ -210,11 +210,6 @@ export const I18nProvider: ParentComponent = (props) => {
document.documentElement.lang = activeLocale document.documentElement.lang = activeLocale
}) })
const RTL_LOCALES = new Set<Locale>(["he"])
createEffect(() => {
document.documentElement.dir = RTL_LOCALES.has(locale()) ? "rtl" : "ltr"
})
onCleanup(() => { onCleanup(() => {
globalMessages = previousGlobalMessages globalMessages = previousGlobalMessages
globalLocale = previousGlobalLocale globalLocale = previousGlobalLocale

View File

@@ -114,6 +114,7 @@ export const instanceMessages = {
"instanceShell.sessionChanges.filesChanged": "{count} files changed", "instanceShell.sessionChanges.filesChanged": "{count} files changed",
"instanceShell.sessionChanges.actions.show": "Show changes", "instanceShell.sessionChanges.actions.show": "Show changes",
"instanceShell.gitChanges.noSessionSelected": "Select a session to view git changes.",
"instanceShell.gitChanges.loading": "Loading git changes...", "instanceShell.gitChanges.loading": "Loading git changes...",
"instanceShell.gitChanges.empty": "No git changes yet.", "instanceShell.gitChanges.empty": "No git changes yet.",
"instanceShell.gitChanges.deleted": "Deleted", "instanceShell.gitChanges.deleted": "Deleted",
@@ -126,9 +127,6 @@ export const instanceMessages = {
"instanceShell.filesShell.viewerEmpty": "No file selected.", "instanceShell.filesShell.viewerEmpty": "No file selected.",
"instanceShell.filesShell.hideFiles": "Hide files", "instanceShell.filesShell.hideFiles": "Hide files",
"instanceShell.filesShell.showFiles": "Show files", "instanceShell.filesShell.showFiles": "Show files",
"instanceShell.gitChanges.noSessionSelected": "Select a session to view git changes.",
"instanceShell.gitChanges.loading": "Loading git changes…",
"instanceShell.gitChanges.empty": "No git changes yet.",
"instanceShell.diff.hideUnchanged": "Hide unchanged regions", "instanceShell.diff.hideUnchanged": "Hide unchanged regions",
"instanceShell.diff.showFull": "Show full file", "instanceShell.diff.showFull": "Show full file",
"instanceShell.diff.switchToSplit": "Switch to split view", "instanceShell.diff.switchToSplit": "Switch to split view",

View File

@@ -46,7 +46,7 @@
.virtual-follow-list-controls-container { .virtual-follow-list-controls-container {
position: absolute; position: absolute;
bottom: calc(var(--space-md) + env(safe-area-inset-bottom, 0px)); bottom: calc(var(--space-md) + env(safe-area-inset-bottom, 0px));
right: var(--space-md); inset-inline-end: var(--space-md);
z-index: 20; z-index: 20;
} }