From cdf3c8ab4bb39cba08780e0edbb7a3f4cabf9106 Mon Sep 17 00:00:00 2001
From: salvacybersec <salva@opsecti.local>
Date: Sun, 5 Apr 2026 23:42:01 +0300
Subject: [PATCH] test(06-06): cover scan output dispatch and unknown-format
 error

- Verify output.Names() exposes table, json, csv, sarif
- Assert renderScanOutput wraps output.ErrUnknownFormat and lists valid formats
- Smoke-test JSON and table dispatch paths through the registry
---
 cmd/scan_output_test.go | 52 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 cmd/scan_output_test.go

diff --git a/cmd/scan_output_test.go b/cmd/scan_output_test.go
new file mode 100644
index 0000000..9075678
--- /dev/null
+++ b/cmd/scan_output_test.go
@@ -0,0 +1,52 @@
+package cmd
+
+import (
+	"bytes"
+	"encoding/json"
+	"errors"
+	"strings"
+	"testing"
+
+	"github.com/salvacybersec/keyhunter/pkg/engine"
+	"github.com/salvacybersec/keyhunter/pkg/output"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+// TestScanOutput_FormatNamesIncludeAll guards the OUT-01..04 registration
+// wiring: all four canonical formats must be reachable via output.Names().
+func TestScanOutput_FormatNamesIncludeAll(t *testing.T) {
+	names := output.Names()
+	for _, want := range []string{"table", "json", "csv", "sarif"} {
+		assert.Contains(t, names, want)
+	}
+}
+
+// TestRenderScanOutput_UnknownReturnsError verifies that renderScanOutput
+// surfaces ErrUnknownFormat and includes the valid-format list in the message.
+func TestRenderScanOutput_UnknownReturnsError(t *testing.T) {
+	err := renderScanOutput(nil, "bogus", false, &bytes.Buffer{})
+	require.Error(t, err)
+	assert.True(t, errors.Is(err, output.ErrUnknownFormat), "error should wrap output.ErrUnknownFormat, got: %v", err)
+	assert.Contains(t, err.Error(), "valid:")
+}
+
+// TestRenderScanOutput_JSONSucceeds ensures the JSON formatter is wired up and
+// produces a valid empty JSON array for zero findings.
+func TestRenderScanOutput_JSONSucceeds(t *testing.T) {
+	var buf bytes.Buffer
+	err := renderScanOutput([]engine.Finding{}, "json", false, &buf)
+	require.NoError(t, err)
+	var out []any
+	require.NoError(t, json.Unmarshal(buf.Bytes(), &out))
+	assert.Len(t, out, 0)
+}
+
+// TestRenderScanOutput_TableEmpty ensures the default table formatter is
+// wired up and emits the canonical empty-state message.
+func TestRenderScanOutput_TableEmpty(t *testing.T) {
+	var buf bytes.Buffer
+	err := renderScanOutput(nil, "table", false, &buf)
+	require.NoError(t, err)
+	assert.True(t, strings.Contains(buf.String(), "No API keys found"))
+}