Fix Feynman onboarding and local install reliability
This commit is contained in:
@@ -1,4 +1,6 @@
|
||||
const MIN_NODE_VERSION = "20.19.0";
|
||||
const MAX_NODE_MAJOR = 24;
|
||||
const PREFERRED_NODE_MAJOR = 22;
|
||||
|
||||
function parseNodeVersion(version) {
|
||||
const [major = "0", minor = "0", patch = "0"] = version.replace(/^v/, "").split(".");
|
||||
@@ -16,16 +18,20 @@ function compareNodeVersions(left, right) {
|
||||
}
|
||||
|
||||
function isSupportedNodeVersion(version = process.versions.node) {
|
||||
return compareNodeVersions(parseNodeVersion(version), parseNodeVersion(MIN_NODE_VERSION)) >= 0;
|
||||
const parsed = parseNodeVersion(version);
|
||||
return compareNodeVersions(parsed, parseNodeVersion(MIN_NODE_VERSION)) >= 0 && parsed.major <= MAX_NODE_MAJOR;
|
||||
}
|
||||
|
||||
function getUnsupportedNodeVersionLines(version = process.versions.node) {
|
||||
const isWindows = process.platform === "win32";
|
||||
const parsed = parseNodeVersion(version);
|
||||
return [
|
||||
`feynman requires Node.js ${MIN_NODE_VERSION} or later (detected ${version}).`,
|
||||
isWindows
|
||||
? "Install a newer Node.js from https://nodejs.org, or use the standalone installer:"
|
||||
: "Switch to Node 20 with `nvm install 20 && nvm use 20`, or use the standalone installer:",
|
||||
`feynman supports Node.js ${MIN_NODE_VERSION} through ${MAX_NODE_MAJOR}.x (detected ${version}).`,
|
||||
parsed.major > MAX_NODE_MAJOR
|
||||
? "This newer Node release is not supported yet because native Pi packages may fail to build."
|
||||
: isWindows
|
||||
? "Install a supported Node.js release from https://nodejs.org, or use the standalone installer:"
|
||||
: `Switch to a supported Node release with \`nvm install ${PREFERRED_NODE_MAJOR} && nvm use ${PREFERRED_NODE_MAJOR}\`, or use the standalone installer:`,
|
||||
isWindows
|
||||
? "irm https://feynman.is/install.ps1 | iex"
|
||||
: "curl -fsSL https://feynman.is/install | bash",
|
||||
|
||||
Reference in New Issue
Block a user