salvacybersec/feynman
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: respect feynman agent dir in vendored pi-subagents

Browse Source
This commit is contained in:
Advait Paliwal
2026-03-28 21:44:50 -07:00
parent 62d63be1d8
commit ab8a284c74
5 changed files with 254 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

104
tests/pi-subagents-patch.test.ts Normal file
View File

@@ -0,0 +1,104 @@
import test from "node:test";
import assert from "node:assert/strict";
import { patchPiSubagentsSource } from "../scripts/lib/pi-subagents-patch.mjs";
const CASES = [
{
name: "index.ts config path",
file: "index.ts",
input: [
'import * as os from "node:os";',
'import * as path from "node:path";',
'const configPath = path.join(os.homedir(), ".pi", "agent", "extensions", "subagent", "config.json");',
"",
].join("\n"),
original: 'const configPath = path.join(os.homedir(), ".pi", "agent", "extensions", "subagent", "config.json");',
expected: 'const configPath = path.join(resolvePiAgentDir(), "extensions", "subagent", "config.json");',
},
{
name: "agents.ts user agents dir",
file: "agents.ts",
input: [
'import * as os from "node:os";',
'import * as path from "node:path";',
'const userDir = path.join(os.homedir(), ".pi", "agent", "agents");',
"",
].join("\n"),
original: 'const userDir = path.join(os.homedir(), ".pi", "agent", "agents");',
expected: 'const userDir = path.join(resolvePiAgentDir(), "agents");',
},
{
name: "artifacts.ts sessions dir",
file: "artifacts.ts",
input: [
'import * as os from "node:os";',
'import * as path from "node:path";',
'const sessionsBase = path.join(os.homedir(), ".pi", "agent", "sessions");',
"",
].join("\n"),
original: 'const sessionsBase = path.join(os.homedir(), ".pi", "agent", "sessions");',
expected: 'const sessionsBase = path.join(resolvePiAgentDir(), "sessions");',
},
{
name: "run-history.ts history file",
file: "run-history.ts",
input: [
'import * as os from "node:os";',
'import * as path from "node:path";',
'const HISTORY_PATH = path.join(os.homedir(), ".pi", "agent", "run-history.jsonl");',
"",
].join("\n"),
original: 'const HISTORY_PATH = path.join(os.homedir(), ".pi", "agent", "run-history.jsonl");',
expected: 'const HISTORY_PATH = path.join(resolvePiAgentDir(), "run-history.jsonl");',
},
{
name: "skills.ts agent dir",
file: "skills.ts",
input: [
'import * as os from "node:os";',
'import * as path from "node:path";',
'const AGENT_DIR = path.join(os.homedir(), ".pi", "agent");',
"",
].join("\n"),
original: 'const AGENT_DIR = path.join(os.homedir(), ".pi", "agent");',
expected: "const AGENT_DIR = resolvePiAgentDir();",
},
{
name: "chain-clarify.ts chain save dir",
file: "chain-clarify.ts",
input: [
'import * as os from "node:os";',
'import * as path from "node:path";',
'const dir = path.join(os.homedir(), ".pi", "agent", "agents");',
"",
].join("\n"),
original: 'const dir = path.join(os.homedir(), ".pi", "agent", "agents");',
expected: 'const dir = path.join(resolvePiAgentDir(), "agents");',
},
];
for (const scenario of CASES) {
test(`patchPiSubagentsSource rewrites ${scenario.name}`, () => {
const patched = patchPiSubagentsSource(scenario.file, scenario.input);
assert.match(patched, /function resolvePiAgentDir\(\): string \{/);
assert.match(patched, /process\.env\.PI_CODING_AGENT_DIR\?\.trim\(\)/);
assert.ok(patched.includes(scenario.expected));
assert.ok(!patched.includes(scenario.original));
});
}
test("patchPiSubagentsSource is idempotent", () => {
const input = [
'import * as os from "node:os";',
'import * as path from "node:path";',
'const configPath = path.join(os.homedir(), ".pi", "agent", "extensions", "subagent", "config.json");',
"",
].join("\n");
const once = patchPiSubagentsSource("index.ts", input);
const twice = patchPiSubagentsSource("index.ts", once);
assert.equal(twice, once);
});