f3c54df283
Closes #261 ## Summary - improve startup remote URL selection when the server binds to `0.0.0.0` - print additional reachable remote URLs instead of advertising only the first external address - add targeted tests for address ordering and advertisability behavior ## Problem When CodeNomad was started with `--host 0.0.0.0`, the CLI chose the first external IPv4 address it discovered and displayed only that one as the remote URL. On Windows machines with WSL, Hyper-V, Docker, or other virtual adapters, that often surfaced a virtual `172.x.x.x` address even though a more useful LAN address such as `192.168.x.x` was also reachable and usable from other devices. That made remote access look broken or confusing even though the server itself was accessible. ## What changed - reuse the resolved network-address list for both: - primary remote URL selection - startup logging of additional reachable URLs - choose the primary remote URL from the **advertisable** external addresses instead of any external address - print `Other Accessible URLs` when multiple useful remote URLs are available - avoid hard-coding a preference like `192.168 > 10 > 172` - suppress link-local `169.254.*` addresses from user-facing advertised URLs - add tests covering: - stable ordering across RFC1918 address ranges - link-local addresses being non-advertisable - link-local-first discovery not stealing the primary LAN URL ## Why this approach This keeps address derivation in the network-address resolver layer and limits `index.ts` to startup wiring and presentation. It also fixes the misleading terminal output without redesigning binding behavior, TLS behavior, or the server API contract. ## Validation - `npm run typecheck --workspace @neuralnomads/codenomad` - `npx tsx --test '.\\src\\server\\__tests__\\network-addresses.test.ts'` ## Notes - this change is intentionally focused on selection and presentation of reachable addresses - it does not attempt a broader virtual-adapter classification policy beyond suppressing clearly low-value link-local addresses in user-facing output --------- Co-authored-by: Shantur Rathore <i@shantur.com>
521 lines
24 KiB
TypeScript
521 lines
24 KiB
TypeScript
import { Dialog } from "@kobalte/core/dialog"
|
||
import { Switch } from "@kobalte/core/switch"
|
||
import { For, Show, createEffect, createMemo, createSignal } from "solid-js"
|
||
import { toDataURL } from "qrcode"
|
||
import { ChevronDown, ExternalLink, Link2, Loader2, RefreshCw, Shield, Wifi } from "lucide-solid"
|
||
import type { NetworkAddress, ServerMeta } from "../../../server/src/api-types"
|
||
import { serverApi } from "../lib/api-client"
|
||
import { restartCli } from "../lib/native/cli"
|
||
import { serverSettings, setListeningMode } from "../stores/preferences"
|
||
import { showConfirmDialog } from "../stores/alerts"
|
||
import { getLogger } from "../lib/logger"
|
||
import { useI18n } from "../lib/i18n"
|
||
import { splitRemoteAddresses, type RemoteAddressGroups } from "../lib/remote-access-addresses"
|
||
const log = getLogger("actions")
|
||
|
||
|
||
interface RemoteAccessOverlayProps {
|
||
open: boolean
|
||
onClose: () => void
|
||
}
|
||
|
||
export function RemoteAccessOverlay(props: RemoteAccessOverlayProps) {
|
||
const { t } = useI18n()
|
||
const [meta, setMeta] = createSignal<ServerMeta | null>(null)
|
||
const [authStatus, setAuthStatus] = createSignal<{ authenticated: boolean; username?: string; passwordUserProvided?: boolean } | null>(null)
|
||
const [loading, setLoading] = createSignal(false)
|
||
const [applyingListeningMode, setApplyingListeningMode] = createSignal(false)
|
||
const [qrCodes, setQrCodes] = createSignal<Record<string, string>>({})
|
||
const [expandedUrl, setExpandedUrl] = createSignal<string | null>(null)
|
||
const [error, setError] = createSignal<string | null>(null)
|
||
const [passwordFormOpen, setPasswordFormOpen] = createSignal(false)
|
||
const [passwordValue, setPasswordValue] = createSignal("")
|
||
const [passwordConfirm, setPasswordConfirm] = createSignal("")
|
||
const [passwordError, setPasswordError] = createSignal<string | null>(null)
|
||
const [savingPassword, setSavingPassword] = createSignal(false)
|
||
const [showAllAddresses, setShowAllAddresses] = createSignal(false)
|
||
|
||
const addresses = createMemo<NetworkAddress[]>(() => meta()?.addresses ?? [])
|
||
const currentMode = createMemo(() => meta()?.listeningMode ?? serverSettings().listeningMode)
|
||
const allowExternalConnections = createMemo(() => currentMode() === "all")
|
||
const displayAddresses = createMemo<RemoteAddressGroups>(() => {
|
||
const list = addresses()
|
||
if (!allowExternalConnections()) {
|
||
return { recommended: null, hidden: [] }
|
||
}
|
||
return splitRemoteAddresses(list)
|
||
})
|
||
|
||
const refreshMeta = async () => {
|
||
setLoading(true)
|
||
setError(null)
|
||
setPasswordError(null)
|
||
try {
|
||
const [metaResult, authResult] = await Promise.all([serverApi.fetchServerMeta(), serverApi.fetchAuthStatus()])
|
||
setMeta(metaResult)
|
||
setAuthStatus(authResult)
|
||
setShowAllAddresses(false)
|
||
} catch (err) {
|
||
setError(err instanceof Error ? err.message : String(err))
|
||
} finally {
|
||
setLoading(false)
|
||
}
|
||
}
|
||
|
||
createEffect(() => {
|
||
if (props.open) {
|
||
void refreshMeta()
|
||
}
|
||
})
|
||
|
||
const toggleExpanded = async (url: string) => {
|
||
if (expandedUrl() === url) {
|
||
setExpandedUrl(null)
|
||
return
|
||
}
|
||
setExpandedUrl(url)
|
||
if (!qrCodes()[url]) {
|
||
try {
|
||
const dataUrl = await toDataURL(url, { margin: 1, scale: 4 })
|
||
setQrCodes((prev) => ({ ...prev, [url]: dataUrl }))
|
||
} catch (err) {
|
||
log.error("Failed to generate QR code", err)
|
||
}
|
||
}
|
||
}
|
||
|
||
const handleAllowConnectionsChange = async (checked: boolean) => {
|
||
const allow = Boolean(checked)
|
||
const targetMode: "local" | "all" = allow ? "all" : "local"
|
||
if (targetMode === currentMode()) {
|
||
return
|
||
}
|
||
|
||
if (applyingListeningMode()) {
|
||
return
|
||
}
|
||
|
||
const confirmed = await showConfirmDialog(t("remoteAccess.listeningMode.restartConfirm.message"), {
|
||
title: allow ? t("remoteAccess.listeningMode.restartConfirm.title.all") : t("remoteAccess.listeningMode.restartConfirm.title.local"),
|
||
variant: "warning",
|
||
confirmLabel: t("remoteAccess.listeningMode.restartConfirm.confirmLabel"),
|
||
cancelLabel: t("remoteAccess.listeningMode.restartConfirm.cancelLabel"),
|
||
dismissible: false,
|
||
})
|
||
|
||
if (!confirmed) {
|
||
// Switch will revert automatically since `checked` is derived from store state
|
||
return
|
||
}
|
||
|
||
setApplyingListeningMode(true)
|
||
setError(null)
|
||
try {
|
||
// Important: await the config patch before restart so Electron reads the updated mode from disk.
|
||
await setListeningMode(targetMode)
|
||
const restarted = await restartCli()
|
||
if (!restarted) {
|
||
setError(t("remoteAccess.restart.errorManual"))
|
||
} else {
|
||
setMeta((prev) => (prev ? { ...prev, listeningMode: targetMode } : prev))
|
||
}
|
||
} catch (err) {
|
||
setError(err instanceof Error ? err.message : String(err))
|
||
} finally {
|
||
setApplyingListeningMode(false)
|
||
}
|
||
|
||
void refreshMeta()
|
||
}
|
||
|
||
const handleOpenUrl = (url: string) => {
|
||
try {
|
||
window.open(url, "_blank", "noopener,noreferrer")
|
||
} catch (err) {
|
||
log.error("Failed to open URL", err)
|
||
}
|
||
}
|
||
|
||
const handleSubmitPassword = async () => {
|
||
setPasswordError(null)
|
||
|
||
const next = passwordValue()
|
||
const confirm = passwordConfirm()
|
||
|
||
if (next.trim().length < 8) {
|
||
setPasswordError(t("remoteAccess.password.error.tooShort"))
|
||
return
|
||
}
|
||
|
||
if (next !== confirm) {
|
||
setPasswordError(t("remoteAccess.password.error.mismatch"))
|
||
return
|
||
}
|
||
|
||
setSavingPassword(true)
|
||
try {
|
||
const result = await serverApi.setServerPassword(next)
|
||
setAuthStatus({ authenticated: true, username: result.username, passwordUserProvided: result.passwordUserProvided })
|
||
setPasswordValue("")
|
||
setPasswordConfirm("")
|
||
setPasswordFormOpen(false)
|
||
} catch (err) {
|
||
setPasswordError(err instanceof Error ? err.message : String(err))
|
||
} finally {
|
||
setSavingPassword(false)
|
||
}
|
||
}
|
||
|
||
return (
|
||
<Dialog
|
||
open={props.open}
|
||
modal
|
||
onOpenChange={(nextOpen) => {
|
||
if (!nextOpen) {
|
||
props.onClose()
|
||
}
|
||
}}
|
||
>
|
||
<Dialog.Portal>
|
||
<Dialog.Overlay class="modal-overlay remote-overlay-backdrop" />
|
||
<div class="remote-overlay">
|
||
<Dialog.Content class="modal-surface remote-panel" tabIndex={-1}>
|
||
<header class="remote-header">
|
||
<div>
|
||
<p class="remote-eyebrow">{t("remoteAccess.eyebrow")}</p>
|
||
<h2 class="remote-title">{t("remoteAccess.title")}</h2>
|
||
<p class="remote-subtitle">{t("remoteAccess.subtitle")}</p>
|
||
</div>
|
||
<button type="button" class="remote-close" onClick={props.onClose} aria-label={t("remoteAccess.close")}>
|
||
×
|
||
</button>
|
||
</header>
|
||
|
||
<div class="remote-body">
|
||
<section class="remote-section">
|
||
<div class="remote-section-heading">
|
||
<div class="remote-section-title">
|
||
<Shield class="remote-icon" />
|
||
<div>
|
||
<p class="remote-label">{t("remoteAccess.sections.listeningMode.label")}</p>
|
||
<p class="remote-help">{t("remoteAccess.sections.listeningMode.help")}</p>
|
||
</div>
|
||
</div>
|
||
<button class="remote-refresh" type="button" onClick={() => void refreshMeta()} disabled={loading()}>
|
||
<RefreshCw class={`remote-icon ${loading() ? "remote-spin" : ""}`} />
|
||
<span class="remote-refresh-label">{t("remoteAccess.refresh")}</span>
|
||
</button>
|
||
</div>
|
||
|
||
<Switch
|
||
class="remote-toggle"
|
||
checked={allowExternalConnections()}
|
||
onChange={(nextChecked) => {
|
||
void handleAllowConnectionsChange(nextChecked)
|
||
}}
|
||
disabled={loading() || applyingListeningMode()}
|
||
>
|
||
<Switch.Input />
|
||
<Switch.Control class="remote-toggle-switch" data-checked={allowExternalConnections()}>
|
||
<span class="remote-toggle-state">{allowExternalConnections() ? t("remoteAccess.toggle.on") : t("remoteAccess.toggle.off")}</span>
|
||
<Switch.Thumb class="remote-toggle-thumb" />
|
||
</Switch.Control>
|
||
<div class="remote-toggle-copy">
|
||
<span class="remote-toggle-title">{t("remoteAccess.toggle.title")}</span>
|
||
<span class="remote-toggle-caption">
|
||
{allowExternalConnections() ? t("remoteAccess.toggle.caption.all") : t("remoteAccess.toggle.caption.local")}
|
||
</span>
|
||
</div>
|
||
</Switch>
|
||
<p class="remote-toggle-note">
|
||
{t("remoteAccess.toggle.note")}
|
||
</p>
|
||
</section>
|
||
|
||
<section class="remote-section">
|
||
<div class="remote-section-heading">
|
||
<div class="remote-section-title">
|
||
<Shield class="remote-icon" />
|
||
<div>
|
||
<p class="remote-label">{t("remoteAccess.sections.serverPassword.label")}</p>
|
||
<p class="remote-help">{t("remoteAccess.sections.serverPassword.help")}</p>
|
||
</div>
|
||
</div>
|
||
</div>
|
||
|
||
<Show
|
||
when={authStatus() && authStatus()!.authenticated}
|
||
fallback={<div class="remote-card">{t("remoteAccess.authStatus.unavailable")}</div>}
|
||
>
|
||
<div class="remote-card">
|
||
<p class="remote-help">
|
||
{t("remoteAccess.username", { username: authStatus()!.username ?? "codenomad" })}
|
||
</p>
|
||
<p class="remote-help">
|
||
{authStatus()!.passwordUserProvided
|
||
? t("remoteAccess.password.status.set")
|
||
: t("remoteAccess.password.status.unset")}
|
||
</p>
|
||
|
||
<div class="remote-actions" style={{ "justify-content": "flex-start", "margin-top": "12px" }}>
|
||
<button
|
||
class="remote-pill"
|
||
type="button"
|
||
onClick={() => {
|
||
setPasswordFormOpen(!passwordFormOpen())
|
||
setPasswordError(null)
|
||
}}
|
||
>
|
||
{passwordFormOpen()
|
||
? t("remoteAccess.password.actions.cancel")
|
||
: authStatus()!.passwordUserProvided
|
||
? t("remoteAccess.password.actions.change")
|
||
: t("remoteAccess.password.actions.set")}
|
||
</button>
|
||
</div>
|
||
|
||
<Show when={passwordFormOpen()}>
|
||
<div class="selector-input-group" style={{ "margin-top": "12px" }}>
|
||
<label class="text-sm font-medium text-secondary">{t("remoteAccess.password.form.newPassword")}</label>
|
||
<input
|
||
class="selector-input w-full"
|
||
type="password"
|
||
value={passwordValue()}
|
||
onInput={(event) => setPasswordValue(event.currentTarget.value)}
|
||
placeholder={t("remoteAccess.password.form.placeholder")}
|
||
/>
|
||
</div>
|
||
<div class="selector-input-group" style={{ "margin-top": "10px" }}>
|
||
<label class="text-sm font-medium text-secondary">{t("remoteAccess.password.form.confirmPassword")}</label>
|
||
<input
|
||
class="selector-input w-full"
|
||
type="password"
|
||
value={passwordConfirm()}
|
||
onInput={(event) => setPasswordConfirm(event.currentTarget.value)}
|
||
/>
|
||
</div>
|
||
|
||
<Show when={passwordError()}>
|
||
{(message) => <div class="remote-error" style={{ "margin-top": "10px" }}>{message()}</div>}
|
||
</Show>
|
||
|
||
<div class="remote-actions" style={{ "justify-content": "flex-start", "margin-top": "12px" }}>
|
||
<button
|
||
class="remote-pill"
|
||
type="button"
|
||
disabled={savingPassword()}
|
||
onClick={() => void handleSubmitPassword()}
|
||
>
|
||
{savingPassword() ? t("remoteAccess.password.save.saving") : t("remoteAccess.password.save.label")}
|
||
</button>
|
||
</div>
|
||
</Show>
|
||
</div>
|
||
</Show>
|
||
</section>
|
||
|
||
<section class="remote-section">
|
||
|
||
<div class="remote-section-heading">
|
||
<div class="remote-section-title">
|
||
<Wifi class="remote-icon" />
|
||
<div>
|
||
<p class="remote-label">{t("remoteAccess.sections.addresses.label")}</p>
|
||
<p class="remote-help">{t("remoteAccess.sections.addresses.help")}</p>
|
||
</div>
|
||
</div>
|
||
</div>
|
||
|
||
<Show when={!loading()} fallback={<div class="remote-card">{t("remoteAccess.addresses.loading")}</div>}>
|
||
<Show when={!error()} fallback={<div class="remote-error">{error()}</div>}>
|
||
<Show when={displayAddresses().recommended || meta()?.localUrl} fallback={<div class="remote-card">{t("remoteAccess.addresses.none")}</div>}>
|
||
<div class="remote-address-list">
|
||
<Show when={meta()?.localUrl}>
|
||
{(url) => {
|
||
const value = () => url()
|
||
const expandedState = () => expandedUrl() === value()
|
||
const qr = () => qrCodes()[value()]
|
||
return (
|
||
<div class="remote-address">
|
||
<div class="remote-address-main">
|
||
<div>
|
||
<p class="remote-address-url">{value()}</p>
|
||
<p class="remote-address-meta">{t("remoteAccess.address.scope.loopback")}</p>
|
||
</div>
|
||
<div class="remote-actions">
|
||
<button class="remote-pill" type="button" onClick={() => handleOpenUrl(value())}>
|
||
<ExternalLink class="remote-icon" />
|
||
{t("remoteAccess.address.open")}
|
||
</button>
|
||
<button
|
||
class="remote-pill"
|
||
type="button"
|
||
onClick={() => void toggleExpanded(value())}
|
||
aria-expanded={expandedState()}
|
||
>
|
||
<Link2 class="remote-icon" />
|
||
{expandedState() ? t("remoteAccess.address.hideQr") : t("remoteAccess.address.showQr")}
|
||
</button>
|
||
</div>
|
||
</div>
|
||
<Show when={expandedState()}>
|
||
<div class="remote-qr">
|
||
<Show when={qr()} fallback={<Loader2 class="remote-icon remote-spin" aria-hidden="true" />}>
|
||
{(dataUrl) => (
|
||
<img
|
||
src={dataUrl()}
|
||
alt={t("remoteAccess.address.qrAlt", { url: value() })}
|
||
class="remote-qr-img"
|
||
/>
|
||
)}
|
||
</Show>
|
||
</div>
|
||
</Show>
|
||
</div>
|
||
)
|
||
}}
|
||
</Show>
|
||
<Show when={displayAddresses().recommended}>
|
||
{(addressAccessor) => {
|
||
const address = addressAccessor()
|
||
const url = address.remoteUrl
|
||
const expandedState = () => expandedUrl() === url
|
||
const qr = () => qrCodes()[url]
|
||
const scopeLabel = () =>
|
||
address.scope === "external"
|
||
? t("remoteAccess.address.scope.network")
|
||
: address.scope === "loopback"
|
||
? t("remoteAccess.address.scope.loopback")
|
||
: t("remoteAccess.address.scope.internal")
|
||
|
||
return (
|
||
<div class="remote-address">
|
||
<div class="remote-address-main">
|
||
<div>
|
||
<p class="remote-address-url">{url}</p>
|
||
<p class="remote-address-meta">
|
||
{address.family.toUpperCase()} - {scopeLabel()} - {address.ip}
|
||
</p>
|
||
</div>
|
||
<div class="remote-actions">
|
||
<button class="remote-pill" type="button" onClick={() => handleOpenUrl(url)}>
|
||
<ExternalLink class="remote-icon" />
|
||
{t("remoteAccess.address.open")}
|
||
</button>
|
||
<button
|
||
class="remote-pill"
|
||
type="button"
|
||
onClick={() => void toggleExpanded(url)}
|
||
aria-expanded={expandedState()}
|
||
>
|
||
<Link2 class="remote-icon" />
|
||
{expandedState() ? t("remoteAccess.address.hideQr") : t("remoteAccess.address.showQr")}
|
||
</button>
|
||
</div>
|
||
</div>
|
||
<Show when={expandedState()}>
|
||
<div class="remote-qr">
|
||
<Show when={qr()} fallback={<Loader2 class="remote-icon remote-spin" aria-hidden="true" />}>
|
||
{(dataUrl) => (
|
||
<img
|
||
src={dataUrl()}
|
||
alt={t("remoteAccess.address.qrAlt", { url })}
|
||
class="remote-qr-img"
|
||
/>
|
||
)}
|
||
</Show>
|
||
</div>
|
||
</Show>
|
||
</div>
|
||
)
|
||
}}
|
||
</Show>
|
||
|
||
<Show when={displayAddresses().hidden.length > 0}>
|
||
<div class="remote-address-disclosure" data-expanded={showAllAddresses()}>
|
||
<button
|
||
class="remote-address-disclosure-trigger"
|
||
type="button"
|
||
onClick={() => setShowAllAddresses(!showAllAddresses())}
|
||
aria-expanded={showAllAddresses()}
|
||
>
|
||
<span class="remote-address-disclosure-label">
|
||
{showAllAddresses()
|
||
? t("remoteAccess.addresses.actions.hideOther")
|
||
: t("remoteAccess.addresses.actions.showOther", { count: String(displayAddresses().hidden.length) })}
|
||
</span>
|
||
<ChevronDown class={`remote-address-disclosure-chevron ${showAllAddresses() ? "is-expanded" : ""}`} />
|
||
</button>
|
||
|
||
<Show when={showAllAddresses()}>
|
||
<div class="remote-address-disclosure-content">
|
||
<For each={displayAddresses().hidden}>
|
||
{(address) => {
|
||
const url = address.remoteUrl
|
||
const expandedState = () => expandedUrl() === url
|
||
const qr = () => qrCodes()[url]
|
||
const scopeLabel = () =>
|
||
address.scope === "external"
|
||
? t("remoteAccess.address.scope.network")
|
||
: address.scope === "loopback"
|
||
? t("remoteAccess.address.scope.loopback")
|
||
: t("remoteAccess.address.scope.internal")
|
||
return (
|
||
<div class="remote-address">
|
||
<div class="remote-address-main">
|
||
<div>
|
||
<p class="remote-address-url">{url}</p>
|
||
<p class="remote-address-meta">
|
||
{address.family.toUpperCase()} • {scopeLabel()} • {address.ip}
|
||
</p>
|
||
</div>
|
||
<div class="remote-actions">
|
||
<button class="remote-pill" type="button" onClick={() => handleOpenUrl(url)}>
|
||
<ExternalLink class="remote-icon" />
|
||
{t("remoteAccess.address.open")}
|
||
</button>
|
||
<button
|
||
class="remote-pill"
|
||
type="button"
|
||
onClick={() => void toggleExpanded(url)}
|
||
aria-expanded={expandedState()}
|
||
>
|
||
<Link2 class="remote-icon" />
|
||
{expandedState() ? t("remoteAccess.address.hideQr") : t("remoteAccess.address.showQr")}
|
||
</button>
|
||
</div>
|
||
</div>
|
||
<Show when={expandedState()}>
|
||
<div class="remote-qr">
|
||
<Show when={qr()} fallback={<Loader2 class="remote-icon remote-spin" aria-hidden="true" />}>
|
||
{(dataUrl) => (
|
||
<img
|
||
src={dataUrl()}
|
||
alt={t("remoteAccess.address.qrAlt", { url })}
|
||
class="remote-qr-img"
|
||
/>
|
||
)}
|
||
</Show>
|
||
</div>
|
||
</Show>
|
||
</div>
|
||
)
|
||
}}
|
||
</For>
|
||
</div>
|
||
</Show>
|
||
</div>
|
||
</Show>
|
||
</div>
|
||
</Show>
|
||
</Show>
|
||
</Show>
|
||
</section>
|
||
</div>
|
||
</Dialog.Content>
|
||
</div>
|
||
</Dialog.Portal>
|
||
</Dialog>
|
||
)
|
||
}
|