salvacybersec/CodeNomad
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #190 from VooDisss/issue-187

Browse Source 
fix(ui): prevent timeline auto-scroll when removing badges (#189)
This commit is contained in:
Shantur Rathore
2026-02-23 21:50:56 +00:00
committed by GitHub
parent e4e89008b2 96fe1b86dd
commit f8aae56728
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/ui/src/components/message-timeline.tsx
View File

@@ -1,4 +1,4 @@
import { For, Show, createEffect, createMemo, createSignal, onCleanup, type Component } from "solid-js" import { For, Show, createEffect, createMemo, createSignal, onCleanup, on, untrack, type Component } from "solid-js"
import MessagePreview from "./message-preview" import MessagePreview from "./message-preview"
import { messageStoreBus } from "../stores/message-v2/bus" import { messageStoreBus } from "../stores/message-v2/bus"
import type { ClientPart } from "../types/message" import type { ClientPart } from "../types/message"
@@ -350,11 +350,9 @@ const MessageTimeline: Component<MessageTimelineProps> = (props) => {
clearCloseTimer() clearCloseTimer()
}) })
createEffect(() => { createEffect(on(() => props.activeMessageId, (activeId) => {
const activeId = props.activeMessageId
if (!activeId) return if (!activeId) return
const targetSegment = props.segments.find((segment) => segment.messageId === activeId) const targetSegment = untrack(() => props.segments).find((segment) => segment.messageId === activeId)
if (!targetSegment) return if (!targetSegment) return
const element = buttonRefs.get(targetSegment.id) const element = buttonRefs.get(targetSegment.id)
if (!element) return if (!element) return
@@ -366,7 +364,7 @@ const MessageTimeline: Component<MessageTimelineProps> = (props) => {
window.clearTimeout(timer) window.clearTimeout(timer)
} }
}) })
}) }))
createEffect(() => { createEffect(() => {
const element = tooltipElement() const element = tooltipElement()