fix(ui): stabilize prompt async optimistic messages

Reconcile optimistic user messages by replacing the oldest synthetic pending message when the server-backed message arrives. Stop sending prompt part ids and rely on message-level replacement so v1.2.25 validation passes without duplicating optimistic content.
This commit is contained in:
Shantur Rathore
2026-03-13 19:17:55 +00:00
parent d9068ac8c6
commit 8ff4019839
5 changed files with 26 additions and 24 deletions

View File

@@ -5,7 +5,7 @@ import { getQuestionCallId, getQuestionMessageId } from "../../types/question"
import type { Message, MessageInfo, ClientPart } from "../../types/message" import type { Message, MessageInfo, ClientPart } from "../../types/message"
import type { Session } from "../../types/session" import type { Session } from "../../types/session"
import { messageStoreBus } from "./bus" import { messageStoreBus } from "./bus"
import type { MessageStatus, SessionRevertState } from "./types" import type { MessageStatus, ReplaceMessageIdOptions, SessionRevertState } from "./types"
interface SessionMetadata { interface SessionMetadata {
id: string id: string
@@ -121,10 +121,10 @@ export function applyPartDeltaV2(
}) })
} }
export function replaceMessageIdV2(instanceId: string, oldId: string, newId: string): void { export function replaceMessageIdV2(instanceId: string, oldId: string, newId: string, options?: Omit<ReplaceMessageIdOptions, "oldId" | "newId">): void {
if (!oldId || !newId || oldId === newId) return if (!oldId || !newId || oldId === newId) return
const store = messageStoreBus.getOrCreate(instanceId) const store = messageStoreBus.getOrCreate(instanceId)
store.replaceMessageId({ oldId, newId }) store.replaceMessageId({ oldId, newId, ...(options ?? {}) })
} }
function extractPermissionMessageId(permission: PermissionRequestLike): string | undefined { function extractPermissionMessageId(permission: PermissionRequestLike): string | undefined {

View File

@@ -586,10 +586,10 @@ export function createInstanceMessageStore(instanceId: string, hooks?: MessageSt
bufferPendingPart({ messageId: input.messageId, part: input.part, receivedAt: Date.now() }) bufferPendingPart({ messageId: input.messageId, part: input.part, receivedAt: Date.now() })
return return
} }
const partId = ensurePartId(input.messageId, input.part, message.partIds.length) const partId = ensurePartId(input.messageId, input.part, message.partIds.length)
const cloned = clonePart(input.part) const cloned = clonePart(input.part)
setState( setState(
"messages", "messages",
input.messageId, input.messageId,
@@ -792,6 +792,8 @@ export function createInstanceMessageStore(instanceId: string, hooks?: MessageSt
id: options.newId, id: options.newId,
isEphemeral: false, isEphemeral: false,
updatedAt: Date.now(), updatedAt: Date.now(),
partIds: options.clearParts ? [] : existing.partIds,
parts: options.clearParts ? {} : existing.parts,
} }
setState("messages", options.newId, cloned) setState("messages", options.newId, cloned)

View File

@@ -152,6 +152,7 @@ export interface PartUpdateInput {
export interface ReplaceMessageIdOptions { export interface ReplaceMessageIdOptions {
oldId: string oldId: string
newId: string newId: string
clearParts?: boolean
} }
export interface ScrollCacheKey { export interface ScrollCacheKey {

View File

@@ -94,7 +94,7 @@ async function sendMessage(
} }
const messageId = createId("msg") const messageId = createId("msg")
const textPartId = createId("part") const textPartId = createId("prt")
const resolvedPrompt = resolvePastedPlaceholders(prompt, attachments) const resolvedPrompt = resolvePastedPlaceholders(prompt, attachments)
@@ -110,7 +110,6 @@ async function sendMessage(
const requestParts: any[] = [ const requestParts: any[] = [
{ {
id: textPartId,
type: "text" as const, type: "text" as const,
text: resolvedPrompt, text: resolvedPrompt,
}, },
@@ -120,9 +119,8 @@ async function sendMessage(
for (const att of attachments) { for (const att of attachments) {
const source = att.source const source = att.source
if (source.type === "file") { if (source.type === "file") {
const partId = createId("part") const partId = createId("prt")
requestParts.push({ requestParts.push({
id: partId,
type: "file" as const, type: "file" as const,
url: att.url, url: att.url,
mime: source.mime, mime: source.mime,
@@ -148,9 +146,8 @@ async function sendMessage(
continue continue
} }
const partId = createId("part") const partId = createId("prt")
requestParts.push({ requestParts.push({
id: partId,
type: "text" as const, type: "text" as const,
text: value, text: value,
}) })
@@ -184,7 +181,6 @@ async function sendMessage(
}) })
const requestBody = { const requestBody = {
messageID: messageId,
parts: requestParts, parts: requestParts,
...(session.agent && { agent: session.agent }), ...(session.agent && { agent: session.agent }),
...(session.model.providerId && ...(session.model.providerId &&

View File

@@ -240,19 +240,22 @@ function resolveMessageRole(info?: MessageInfo | null): MessageRole {
return info?.role === "user" ? "user" : "assistant" return info?.role === "user" ? "user" : "assistant"
} }
function findPendingMessageId( function findPendingSyntheticMessageId(
store: InstanceMessageStore, store: InstanceMessageStore,
sessionId: string, sessionId: string,
role: MessageRole, role: MessageRole,
): string | undefined { ): string | undefined {
const messageIds = store.getSessionMessageIds(sessionId) const messageIds = store.getSessionMessageIds(sessionId)
const lastId = messageIds[messageIds.length - 1] for (const messageId of messageIds) {
if (!lastId) return undefined const record = store.getMessage(messageId)
const record = store.getMessage(lastId) if (!record) continue
if (!record) return undefined if (record.sessionId !== sessionId) continue
if (record.sessionId !== sessionId) return undefined if (record.role !== role) continue
if (record.role !== role) return undefined if (record.status !== "sending") continue
return record.status === "sending" ? record.id : undefined if (!record.isEphemeral) continue
return record.id
}
return undefined
} }
function handleMessageUpdate(instanceId: string, event: MessageUpdateEvent | MessagePartUpdatedEvent): void { function handleMessageUpdate(instanceId: string, event: MessageUpdateEvent | MessagePartUpdatedEvent): void {
@@ -282,9 +285,9 @@ function handleMessageUpdate(instanceId: string, event: MessageUpdateEvent | Mes
let record = store.getMessage(messageId) let record = store.getMessage(messageId)
if (!record) { if (!record) {
const pendingId = findPendingMessageId(store, sessionId, role) const pendingId = findPendingSyntheticMessageId(store, sessionId, role)
if (pendingId && pendingId !== messageId) { if (pendingId && pendingId !== messageId) {
replaceMessageIdV2(instanceId, pendingId, messageId) replaceMessageIdV2(instanceId, pendingId, messageId, { clearParts: role === "user" })
record = store.getMessage(messageId) record = store.getMessage(messageId)
} }
} }
@@ -345,9 +348,9 @@ function handleMessageUpdate(instanceId: string, event: MessageUpdateEvent | Mes
let record = store.getMessage(messageId) let record = store.getMessage(messageId)
if (!record) { if (!record) {
const pendingId = findPendingMessageId(store, sessionId, role) const pendingId = findPendingSyntheticMessageId(store, sessionId, role)
if (pendingId && pendingId !== messageId) { if (pendingId && pendingId !== messageId) {
replaceMessageIdV2(instanceId, pendingId, messageId) replaceMessageIdV2(instanceId, pendingId, messageId, { clearParts: role === "user" })
record = store.getMessage(messageId) record = store.getMessage(messageId)
} }
} }