salvacybersec/CodeNomad
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ui): hide download action for local file attachments

Browse Source 
Avoid showing a misleading download icon for file:// attachments in the message stream.
This commit is contained in:
Shantur Rathore
2026-02-14 10:52:15 +00:00
parent 2d93d82611
commit 2d1f702597
1 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
packages/ui/src/components/message-item.tsx
View File

@@ -1,5 +1,5 @@
import { For, Show, createSignal } from "solid-js" import { For, Show, createSignal } from "solid-js"
import { Copy, Split, Trash2, Undo } from "lucide-solid" import { Copy, ExternalLink, Split, Trash2, Undo } from "lucide-solid"
import type { MessageInfo, ClientPart } from "../types/message" import type { MessageInfo, ClientPart } from "../types/message"
import { partHasRenderableText } from "../types/message" import { partHasRenderableText } from "../types/message"
import type { MessageRecord } from "../stores/message-v2/types" import type { MessageRecord } from "../stores/message-v2/types"
@@ -8,6 +8,7 @@ import { copyToClipboard } from "../lib/clipboard"
import { useI18n } from "../lib/i18n" import { useI18n } from "../lib/i18n"
import { showAlertDialog } from "../stores/alerts" import { showAlertDialog } from "../stores/alerts"
import { deleteMessagePart } from "../stores/session-actions" import { deleteMessagePart } from "../stores/session-actions"
import { isTauriHost } from "../lib/runtime-env"
interface MessageItemProps { interface MessageItemProps {
record: MessageRecord record: MessageRecord
@@ -105,7 +106,8 @@ export default function MessageItem(props: MessageItemProps) {
} }
if (url.startsWith("file://")) { if (url.startsWith("file://")) {
window.open(url, "_blank", "noopener") // Local filesystem URLs are not reliably downloadable from the message stream.
// We hide the download action for these chips.
return return
} }
@@ -408,17 +410,20 @@ export default function MessageItem(props: MessageItemProps) {
<img src={attachment.url} alt={name} class="h-5 w-5 rounded object-cover" /> <img src={attachment.url} alt={name} class="h-5 w-5 rounded object-cover" />
</Show> </Show>
<span class="truncate max-w-[180px]">{name}</span> <span class="truncate max-w-[180px]">{name}</span>
<button <Show when={!attachment.url?.startsWith("file://")}>
type="button" <button
onClick={() => void handleAttachmentDownload(attachment)} type="button"
class="attachment-download" onClick={() => void handleAttachmentDownload(attachment)}
aria-label={t("messageItem.attachment.downloadAriaLabel", { name })} class="attachment-download"
> aria-label={t("messageItem.attachment.downloadAriaLabel", { name })}
<svg class="h-3 w-3" fill="none" viewBox="0 0 24 24" stroke="currentColor"> title={t("messageItem.attachment.downloadAriaLabel", { name })}
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 16v2a2 2 0 002 2h12a2 2 0 002-2v-2" /> >
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M8 12l4 4 4-4m-4-8v12" /> <svg class="h-3 w-3" fill="none" viewBox="0 0 24 24" stroke="currentColor">
</svg> <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 16v2a2 2 0 002 2h12a2 2 0 002-2v-2" />
</button> <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M8 12l4 4 4-4m-4-8v12" />
</svg>
</button>
</Show>
<button <button
type="button" type="button"