From df10e6f55f7b7c1617927968b525755efcd15055 Mon Sep 17 00:00:00 2001
From: msramalho <19508417+msramalho@users.noreply.github.com>
Date: Tue, 21 Jun 2022 18:24:04 +0200
Subject: [PATCH] applying feedback

---
 docs/source/_static/favicon.ico | Bin 15086 -> 7774 bytes
 tests/scraper_test.py           |  19 +++++-------
 vk_url_scraper/__init__.py      |   2 +-
 vk_url_scraper/__main__.py      |   2 +-
 vk_url_scraper/scraper.py       |  50 ++++++++++++++++++--------------
 vk_url_scraper/utils.py         |  28 +++++++++++-------
 6 files changed, 56 insertions(+), 45 deletions(-)

diff --git a/docs/source/_static/favicon.ico b/docs/source/_static/favicon.ico
index 1aaa6139b623ca31250621b7c0f08b7d26795f8f..bf73c0f6ebb1cc233fb5c83010151fcb9db92c14 100644
GIT binary patch
literal 7774
zcmeHLTTB#J82;u0yA&wbA{2{lky~4!$ek8zfm%zUE!ct-Xem&jEiIICQ!JNuEyzW7
z=U^ya;0cYAphg}bJP_0bH9ToT&=8`A2MIz#AVIm=Lx{%U9Kyi#ZD%vHv)_0AZ~pWB
z=ggd0fTN$77|^2@`&<AA0G@QG5dNk63clXPaU6J_had<LMG+<@CNMQMg+`-+R;z`X
znHkK@&0%3-0ZU6uSXo)Y+S(d6Ha4)ewS}FX9qjGx;o#r^CnqO3J3GV0#Raaeu5fd6
zgS)#sJUl$$>FEhCFE4m|d&9@a2fn_(@bmM7zrQ~M0s;^i7>J;tAOr^oBP1jQp`oD&
z3kySdcsL>=A`lrFiKwV3L`O%{{>C6SHWqPlafpwPM?yjZ5)%`Vl$3<z<Yc6zq#!jl
z6=`W{NKa2kMn(oQGc%Eum4)o=Y~<wRAU8J`d3kxr&(B9eK>-R23sF>5gyQ02l$4a9
zw6qjuWo0NYFGod11u82mQB_q1olb}9>T1-~)S$Mu7WMV@kR%CBO-(p{{5YDMo6*wJ
zf)giB;N;1ZICbh2PM<!F*49?EwY8zWy&Y%HoWa?%XL0V_Ih;R#9vvMW=<Mvog$oyO
z@!~~Xx^xMbFJDGiR~NdwyV29rgWld=^!4?jzrP<>u3W*@t5<RD+BFOe4B-0p>$q{_
z25#QGiNV1^+`4rOw{PFZ(9jTuhlg?J&K=yndlw@kBN!bW#l3s?aR2^&Jb3T`V`F1@
z`0ydd$Hy@-F@Z;q9$|8F5>r!Cn4X@-%*+gCXJ;`tH;2cMALGfBCzzj~$HKw_78e(>
zw6uif<z+m5`gFZvX5@?x7#%P=@IN}h3xX){0=LCW@VveMS6M}6m1TwL(eJ(@Y+jBx
zdH<I>gCvoaO_B^pzS+)iE<29jS)ivn^g$!79*9)8-)2){V))UObpHAA(_LP!Zr*#o
z*U_K)LvL-OpTb8CgcuHgVD&uK^20x=TD8}6V529(dvy{ymSFK>d+yb5X{UADU&J<Y
zZgEhO^k1$i9LIk~#eO$a=-F=S_s`mwf`mkg=s$i5UN<}b4~aC&*=%{3kSg<aW7m=n
z1|sE&Yf<`}4{9X(5MG91LVk2K?2~0Rm4xId(u$&5zOq_eJRvn^vJ?Z1p;|j-InIw(
z<xN?N0j_At2XNc;#1Oy;lZ8K_T8sg%ttC>VY!Cwspjx}+Iq`2IMaxt2s0-DKm8Zm_
z^706IN*>kzMM&YA8T70rePd8G@c9FD+`sWGdW+vX8zm`4(dF3}6f+D`{W~g&IaU*L
z=ru)?g_#*2+(4w?tW*)>#4q$jpKHe`CNl?Ff;0V^&X!_Fbu!cJHxPY=yE+BX#x)Y@
zh_5<g;^%ro>cUhJ<HQJB&0~AiDS!}GN2G>ObqXK^(#($TkS(=RkP~;)XHvG(Fh+aR
zG`bqt#vm2K+}pI6!3u*|%{5hoFmAG}5GKy$6Oznil@WXfAwMV!VYcSJBP5f_DkM?~
z`AK02v$={|e0Wk)gevo!uDR%@%Is!#+(@t-;HdX1m65aEo1MMaS`{^?g9f@9D|=mq
z`?Sfgt1pmwTOVTF4w}`<X4v|2jPqShix_-Zwb?lC_AD>?_5Q|%=>OfClGVgYO_hW(
t+Ir|##B`o2)Ddt@DlI+Wtcn!vr_yCOqlZS==z!4yqXR|<j1H`I;6E{pk>UUV

literal 15086
zcmche30ze7wZ|`;?1Ba{BFcy$3`0`ezE8Tn_oNs#Br!3{z|*vbG_5ghp0P=q^)*hK
z*EFUt(JXD6nAB{(r$$9ZKon&V7gU&GbBV@43UR3tKx9YG`<*-UpSj%59j+*y59jm0
z+y9*J|J?uG&N)bukK`v!pDv*_Nb3_N={8A{3<l?Vq$GWbZINhs|5ATRdKm{K;}~?2
zav;2&e-<34{<UrkJ<_^0tnqSQXyfI4NI^(rdtq?nl_E%SP-91NU}M+bz%y5@qc-%G
z1$;~0e<aqc7o>d8ZZ^GZ&r03sO{y|e-e@lhUe~&5G_`FBr_0;Is68)~+6zJm{M1n#
zM4fwssLL8i-TOvSPuZxx?*0C=MuJ)BtTLOHfc+|jh7wz*>6Od-1C!czgizboFv2;Y
z_WV$~vNMD_b_Y}E9<Y~yy%bUg{sRHjdobVv*`#s8-i>T4%%;iU?;48RxqqN4J9!%0
zZ`%`e*u`E5_FZoFE@o%n?;pkN)LZUPeMkIv6G^@|lAU$g%%*2_vh%q)Anac*4tl7q
zD2T2wJLXNNdftG&N3b9Er~adUbhXm=Inn<{wP32!%U_k1`ZHno;x;L~r7*a?wGeZj
z=Z%>2%6W4rfcn7R2loC-@Y{X+`|LOFTBulXOR`>e9M^vGo}_TW&u#OLkoTMOLa2S0
zhdB>+=e(i*3b5OJnV+s!`JSZ;X@XMEaF=nPvFPT{GObbDY0eA&!Nsj1bTJp#FXoSj
zIWM#KyV+@=+K0tXC#6BYQ0vyS4)&9J`75)H-&gCz_2_e9OX$f9n?mWr<}l*xR-W_D
zdBbzwId9nS4)z-Gv()(%(`hMCtyAxMb+++4df9P*I-#Za!e^mRoZApa=hlbOh0nsM
z8`tfiInTZa`yl>WAEG*m=$Q0Z_JNjeZ`<uzrj^&g|G1W}^B;#rpZ&k^p0C%1)7PJd
z)42`d)C2#k=DgeYZg%D;IxfAfrCVz|;q?IQ^*Z@`s_(lsT1yviZ(0|=sp*r^)c7&v
zqtWshdXM;v>va(OfSTVihNrygSMRfDrv6YTJ7Ml@QukM{gE`}GA4bsM)<)1*e~qAq
z4<d-qM=$2T^Llm6c~9)j&r&D-O08FG9ry7!_43;?Q!=#li0!md^84z8h^B`3BdLB3
z<h@Ax^4&=JT=X8n82Ebi#_kxy0Orz==YcGeFWA4<$=|rqZ1xkJ-r9!uB41+WFaI)z
z&b$Np^BDT#Ph*J3)QxADe7!oZS%<%c-_>oM^t3lS@aIgO>{OL$`kgmj%6+HbjhG7N
z0cQT<?Xh(FEy$Z=>C_uz<@Juz0Poy`$MKfdeF^uSH9GkRDza0jDjA1bKK16<V!?cB
z^-c8oD#+_M(aG1)z7|EzJA(C(p-%dUN+f)lxPKK(z8e7cOM3Wm-4?rh>RURsDr%vU
z`Q-mZ(TP7oUX7yTE635XSH{WrSiT<QYj&{DJ#E`bb_riuj$c(~>fL(S`50T4X`$$+
zw{3hqHW<t;ZssVN`Pd)EQQgas-$zsJe@DyLMQ?>~r_M1{QneJz40zx9R40GSLGurS
z^>QnZJGOG%TgTyNHFNDt(Ny!h@l<VrtQe2w=-z(2?;4C@K*u<~=`Q!X6YOnz`1$^-
zWV)7RaDQ9)SuoeU=-{q;VLVm+_GYsG7vy<aehK!Okouv<(6VuKzaDnyG5i@n>>vDG
z;bMlbt6p$3+n$?1mCr(+nLrg!$CR-VeisG*pCOv(;>#B%4f$=$?6__#h7IoQSp7ou
zBQmqo*UW5lF@yW57&`hJ$dfTwk31eTN!Y_PVh+aex%yo2w?p+Jqb`1%IrR~tZ@6vE
zGn2>Ip1-+M_O<NiLCkdIiHUUhamcSB%VGyTb8+AI!*lo%jNy_PNAtQ!UF`6GXU(Ep
z#tfHR*$?yM6NR5;<|9t#^5qk${IOU%^q;X*{%EXS*-tF<eG~jILpshp7pIRuGvyP}
z|9ab_PsXOPp9S+_!Mx1DeehS4=-@9W(Sb+ME-`TE%;WF;+A+6OWu@qf?Nnu%e(X`n
zFgEf#I+)MMeiqD+f)(7%ynpFr+W+umDqAv{_WgX4=6ed_We@AQ?;Kl_NK`BB!rY4+
z2Cm002bWEJ_Ml*P`dToT{erpUXx~F|RQfZ+DUS-U5$q*;_|N|(N<6<iFox%^=i5}U
z?0<Ap41C?kzGgoUW(N0z2D0WDsN?|y?O8nKHqlSC74wY~z&_-CzbZRLj&+FZ-PxYT
zIPMg>hTE1sJUP$pXJ(FbF_$bh(B7X;p}jwuLVFg*uTtBvXPTDl@qN`IV-c8_K@LOI
z&yZql`<`02-t~PC8RiLQEBri&`F?OOil^fLh^O7z@l6(dn<({yy<88!J<B*x^ux0-
z2D}eL@*(0Ki^r5pC!9fbaj=fIBrVO~y4diw%g-|N6e?aQGt=&@c-m#2O1m;y5@rjP
z)#h8LfPFv*|9O6|7X6ehUjuk1{uu1P$6Pvq_8cTfd5oUrz4ynj+_T8R?DVyZxoE*u
zDw>}_JMV+cOZY(OvuCC}tAm|5jw1RD)#BOcOJ}5rp^j7U-<=(2#QcD-;bZt(#Y~0w
zCQ!jWiBvE*v85!<5XAk#Uag0}GCS3%wl@;%m>(s~?ew#fney*Wr2M<4(T+Q(QC>z;
z<~77+<@djl;8p7^oR^rxelB$Qc@XoC3~=8ujkeEDqV2PiKE^xbi+X&IV{+7XMryri
z_N}4tb6fshiL##sbKV><gL~WUkeSJ}H9ff*Ii6EG_}h<}O<^O&>q#$|-(^3$m}fD!
z%*@=f6wKE5o{VS1d!B5J<hHyy({983a4<W3?cx^vrFZM&=X~QxvTErDXRToM)E=Eb
zbPmyOPOa6_KhoQC(~ZkLar3sF`sdE_k>=FWzwzG^#(}lR(-`*6P0{n6(ql7!dqi@v
zTFmP0+tQ62{*m8E6$^CC9pu;5`u^GLx#`KX)%-i>=(}$5jWy?=&8xPz(Jc9azfn1c
zvU_yR9o_M8wapv7j&ooU{M+#iz%y&exsRCUZ*MfmaP@6YH^zbg>UKN_4$T{y9na&o
zBWBah!?iaO{R(bR`rzQbDUId#nVPkvVnIqJ-jP45T#$O}4P%HP>SkquM6KNV5jCK(
zAS~X1Y^bY6TFZ)ctF(fwe%#J*wsB-Z=C?tLaJ8HXZiPaAJ8y+TN9!}dEo=>NQ~~Y3
zbK5T=9z8>D!<?-@w*$<w!rc;w-iiP4nk2WQ9jzq-h*-1)Hi%Z<Zw+i<J%F^b9cn-e
zE)2>#3gbX)3ACbZ^|3?%0)w|iupWTLd1`UY4BjqU0IuM5b<5j43VV|GiPj2FJL<Fy
zk|d=;Ty<I)s`}TuJ@gdnv^v`ILOW33)Pee@j?Uu1j?TTKE_Ia#yu*1vb)RclN9{}s
zWHZNX)q?N04OfbTUlTP-a-9t7OuA5K!nH|U+tYm@;Eijsr#zNxL2ykrX}>3@KHst@
zDDHAm@Br6#$@N8|#szgzTvvoV{{U(fh7}`0ocE{NwoO-U^Nn%L`%Pg`(dC`a+9s=_
zCW~vDxF*Qv+e(#Ef^uwnmhldkuVo+SWT(*4oFANZDKFSvU&8fZT%Upbx~R>N>q!nu
zy7M(0BZloBE&Dk4W?}zyffV@nEuoh#=7vz$zCed<u7~2997jEloL|0L>$@Ivdr<sE
z=uo$qYg{j<^}M-sIwJvBt^0R&ec0-A>%-~qn?vO|nOuwItm}~T^X}aCYIiT~CD`7p
zX+O*K4{@-jb)nOnK6TVLaE(bXk6lp@Bj=_?F7deZine7*;%5+SYsLg^*`{xK>W}(_
zqjGHm^5JLyHyr*)J&smhAMsC5I(QrA-D8?#H=7P?^{anx%+h+1pGR)K@x#&7XT$AG
zD<`j!hp#fH9@4VU^Fq`9s>n#>);s0gx|~<P3AF;K4JZeL@V&Z4Z4Bll?);7)*E+(s
zR!r?m`TYraz-a$Ie`CzYoL@f4IdNxhncLPPJV@2H-Rqx<So9FJifgqkJNBG-J!%H$
zhL5jw<b^pW%=zFN<W?~+FM^>@gJTc2kHy$EYYpN1e;vv``w}+K$oWyu=eqKuj{G97
z&m6=Vt35HGKG9pv$me)0y3Ug~j@p;TKg&5}ksm~!&5_T1dIBANYT_z6=6OuAfT2st
zaqjJCt@{ljmN6&?=gq#&5*35oZ=Wk4$+^fUV;niXUr%h}`WWsH+mj(%1;g>BiCXsi
zI8Wfsrg|Upa(SHpl=FzlA<FqU&JjHti~P{!nabml)A`|*{19((@U6<@^(-HLB4(bP
zPZN15MNX>h7n9ys>%hEwRqL9+xOQy*wbnv%yc>D2^9PVqa_458xugf<nh{qUB^Y>K
z!FIhT`*jZ{IqIU0NoR4M9@P8%V%^ANy(;H}<ouO0r{c_~6#v99PuR!1`;R=?=51d*
zZ76`<LlBWOsYH%phUn|9EzOBdMDA&Tb5ERG*rUvaWW~E`-f+)(OUpjTiP;9`$avhx
z9{|UCNHgR!&VzWf&-;)!+Arq?9QhYlY<=hagpPuYgwb641>5H}>{~tQ$2stW{pmb!
zJ?&R++nqgiu^i7w?gTbD|KN%*@3<@BAzPO5b`9Ia?|({N!&%;jcUahLm-7d6IR@{D
z4a+gsS;;$aPkmp*erv_t?}iM=rn*o5-3e>txW9<&a(oou#1O9O|HhMj<b>Z*>lyC)
z_6+0qT`^f_44LB!yYA4A=hzmc{>yOfdFlsyCqyhmwEH#UF}NOTJn6WeZSeKu!Y;Sl
zAe9>N6kAs6vg@(ssqdEAQ=?(m71P|Eq3QdciiOjnJn6XJZCht1ZxTK@aIfcB7<|9}
zdhKZS&rP3}!S?fK8F6iU{<g50Z_#yc)w1DjJLjGYXD8Q`-<Q&LG}F|p6!3h3_ioL1
za!tJ}@bp@NV8e_7$r3lfK??*h`hBc{{eD)zZodYf?!X3#WqM$%6dBPfNwRP_quW=C
z>-V$Fz>#s>3%&gyY0%gW!EM$Vmf+9?hb4qG;9XXh2;zrBB*Xv_af-A-6`j~|gML@6
z0rj}=JKm$~q}5t#?dFsm#XYS>99O#ZW=ltzzxzGBPFgPZDO>a{5&bJOQ!HX%?i~ih
z-o+E${h6gs{&zZYh-9BPJyP_QTdccwVj*|tl#<HlqVRp_E5^~H)KQr^=>JVhlzn-5
zbGji1I*2(u=}@xQWTxD!?$7J!U(Y&<%#+CF(>kf8`IAVCg1v>u;;H|ZnNvRG{tk&>
zi}(4*Fou?Me{#P+S1w4=JU{G5SO4@W^=yM{!D<#8TZH|lKaTf!ZUhhdm$-DK8PZVi
zpC<a&K9FPwQwf+>D{FH_Uv7mT#Tb-+ugo;cw&nV?S~&!#>?$wkrWqo0)2Fn^{V@jE
z7VMgSQ!5dEESxjd_1^EzZ|eTJw;R&fe(BsKSATnEa+>-$Z|ixp<LfcUMSr`uW3Oi)
x-%S4Sl_b3cd9f66VpJ7a@fFg5=wt&TIbU&X*aw0LRci!pKyeP~pW(O>{Xa6LG2Z|H

diff --git a/tests/scraper_test.py b/tests/scraper_test.py
index 5178f45..2f31b7b 100644
--- a/tests/scraper_test.py
+++ b/tests/scraper_test.py
@@ -2,17 +2,16 @@ import datetime
 import os
 import tempfile
 
+import pytest
+
 from vk_url_scraper import VkScraper
 
-# import pytest
-
-
 vks = None
 
 
-# def test_login_fail():
-#     with pytest.raises(Exception):
-#         VkScraper("invalid", "combination")
+def test_login_fail():
+    with pytest.raises(Exception):
+        VkScraper("invalid", "combination")
 
 
 def test_login_success():
@@ -102,7 +101,7 @@ def test_scrape_download_multiple_media():
             "wall-17315087_74182_2.jpg",
             "wall-17315087_74182_3.jpg",
             "wall-17315087_74182_4.jpg",
-            "wall-17315087_74182_0.mkv",
+            "wall-17315087_74182_0.mp4",
         }
         found_files = set(os.listdir(tempdir))
         assert len(expect_files) == len(expect_files & found_files)
@@ -138,8 +137,4 @@ def test_scrape_video_only2():
     with tempfile.TemporaryDirectory(dir="./") as tempdir:
         vks.download_media(res, tempdir)
         found_files = set(os.listdir(tempdir))
-        # different systems might attribute different extension
-        assert (
-            "video-17546758_456239898_0.webm" in found_files
-            or "video-17546758_456239898_0.mp4" in found_files
-        )
+        assert "video-17546758_456239898_0.mp4" in found_files
diff --git a/vk_url_scraper/__init__.py b/vk_url_scraper/__init__.py
index 9f50225..499c193 100644
--- a/vk_url_scraper/__init__.py
+++ b/vk_url_scraper/__init__.py
@@ -1,2 +1,2 @@
 from .scraper import VkScraper
-from .utils import DateTimeEncoder, mkdir_if_not_exists
+from .utils import DateTimeEncoder, suppress_stdout
diff --git a/vk_url_scraper/__main__.py b/vk_url_scraper/__main__.py
index 3ebf819..a2a7738 100644
--- a/vk_url_scraper/__main__.py
+++ b/vk_url_scraper/__main__.py
@@ -35,7 +35,7 @@ def get_argument_parser():
         action="store",
         dest="token",
         required=False,
-        help="optional token, when passed authentication will not be performed - good to avoid captcha issues",
+        help="optional token, when passed username/password authentication will not be done - good to avoid captcha issues",
     )
     parser.add_argument(
         "-d",
diff --git a/vk_url_scraper/scraper.py b/vk_url_scraper/scraper.py
index 2d73b92..54fd3f3 100644
--- a/vk_url_scraper/scraper.py
+++ b/vk_url_scraper/scraper.py
@@ -1,5 +1,6 @@
 import os
 import re
+import shutil
 from collections import defaultdict
 from datetime import datetime
 from typing import List
@@ -9,7 +10,7 @@ import requests
 import vk_api  # used to get api_token after authentication
 import yt_dlp  # to download videos from url
 
-from .utils import captcha_handler, mkdir_if_not_exists
+from .utils import captcha_handler, suppress_stdout
 
 
 class VkScraper:
@@ -306,7 +307,7 @@ class VkScraper:
         headers = {
             "User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36"
         }
-        mkdir_if_not_exists(destination)
+        os.makedirs(destination, exist_ok=True)
         downloaded = []
         for r in results:
             for k, attachments in r["attachments"].items():
@@ -319,23 +320,30 @@ class VkScraper:
                             f.write(d.content)
                             downloaded.append(filename)
                 elif k == "video":
-                    for i, url in enumerate(attachments):
-                        filename = os.path.join(destination, f"{r['id']}_{i}.%(ext)s")
-                        ydl = yt_dlp.YoutubeDL(
-                            {
-                                "outtmpl": filename,
-                                "quiet": True,
-                                "restrictfilenames": True,
-                                "forcefilename": True,
-                            }
-                        )
-                        info = ydl.extract_info(url, download=True)
-                        filename = ydl.prepare_filename(info)
-                        if "unknown_video" in filename:
-                            new_filename = filename.replace("unknown_video", "mkv")
-                            with open(filename, "rb") as vin, open(new_filename, "wb") as vout:
-                                vout.write(vin.read())
-                            os.remove(filename)
-                            filename = new_filename
-                        downloaded.append(filename)
+                    with suppress_stdout():  # ytdlp is not 100% quiet
+                        for i, url in enumerate(attachments):
+                            filename = os.path.join(destination, f"{r['id']}_{i}.%(ext)s")
+                            ydl = yt_dlp.YoutubeDL(
+                                {
+                                    "format": "bestvideo[ext=mp4]+bestaudio[ext=m4a]/best[ext=mp4]/best",
+                                    "merge_output_format": "mp4",
+                                    "retries": 5,
+                                    "noplaylist": True,
+                                    "outtmpl": filename,
+                                    "quiet": True,
+                                    "restrictfilenames": True,
+                                    "forcefilename": True,
+                                    "simulate": False,
+                                }
+                            )
+                            info = ydl.extract_info(url, download=True)
+                            filename = ydl.prepare_filename(info)
+                            if "unknown_video" in filename:
+                                print(f"before {filename=}")
+                                filename = shutil.copy(
+                                    filename, filename.replace("unknown_video", "mkv")
+                                )
+                                print(f"after {filename=}")
+                                os.remove(filename)
+                            downloaded.append(filename)
         return downloaded
diff --git a/vk_url_scraper/utils.py b/vk_url_scraper/utils.py
index 77aa5af..b51de5a 100644
--- a/vk_url_scraper/utils.py
+++ b/vk_url_scraper/utils.py
@@ -1,5 +1,7 @@
 import json
 import os
+import sys
+from contextlib import contextmanager
 from datetime import datetime
 
 
@@ -11,15 +13,21 @@ class DateTimeEncoder(json.JSONEncoder):
         return json.JSONEncoder.default(self, o)
 
 
-def mkdir_if_not_exists(folder):
-    if not os.path.exists(folder):
-        os.makedirs(folder)
-
-
 def captcha_handler(captcha):
-    print(
-        f"CAPTCHA DETECTED, please solve it and input the solution. {captcha.sid=} {captcha.get_url()=}",
-        flush=True,
-    )
-    key = input(f"Enter captcha code for {captcha.get_url()}:").strip()
+    key = input(
+        f"CAPTCHA DETECTED, please solve it and input the solution. {captcha.sid=} {captcha.get_url()=}:"
+    ).strip()
     return captcha.try_again(key)
+
+
+@contextmanager
+def suppress_stdout():
+    # https://thesmithfam.org/blog/2012/10/25/temporarily-suppress-console-output-in-python/
+    # this is used to silence ytdlp which does not fully respects quite=True and outputs filenames to the console
+    with open(os.devnull, "w") as devnull:
+        old_stdout = sys.stdout
+        sys.stdout = devnull
+        try:
+            yield
+        finally:
+            sys.stdout = old_stdout