ported vk scraper logic into lib

This commit is contained in:
Miguel Ramalho
2022-06-17 19:15:20 +02:00
parent b3c7ac8e5d
commit 965057619f
32 changed files with 1346 additions and 610 deletions

View File

@@ -6,7 +6,7 @@ body:
- type: markdown
attributes:
value: >
#### Before submitting a bug, please make sure the issue hasn't been already addressed by searching through [the existing and past issues](https://github.com/allenai/python-package-template/issues?q=is%3Aissue+sort%3Acreated-desc+).
#### Before submitting a bug, please make sure the issue hasn't been already addressed by searching through [the existing and past issues](https://github.com/bellingcat/vk-url-scraper/issues?q=is%3Aissue+sort%3Acreated-desc+).
- type: textarea
attributes:
label: 🐛 Describe the bug
@@ -17,7 +17,7 @@ body:
```python
# All necessary imports at the beginning
import my_package
import vk_url_scraper
# A succinct reproducing example trimmed down to the essential parts:
assert False is True, "Oh no!"

View File

@@ -1,5 +1,5 @@
name: 📚 Documentation
description: Report an issue related to https://my-package.readthedocs.io/latest
description: Report an issue related to https://vk-url-scraper.readthedocs.io/latest
labels: 'documentation'
body:
@@ -7,7 +7,7 @@ body:
attributes:
label: 📚 The doc issue
description: >
A clear and concise description of what content in https://my-package.readthedocs.io/latest is an issue.
A clear and concise description of what content in https://vk-url-scraper.readthedocs.io/latest is an issue.
validations:
required: true
- type: textarea

View File

@@ -10,9 +10,9 @@ Changes proposed in this pull request:
## Before submitting
<!-- Please complete this checklist BEFORE submitting your PR to speed along the review process. -->
- [ ] I've read and followed all steps in the [Making a pull request](https://github.com/allenai/beaker-py/blob/main/CONTRIBUTING.md#making-a-pull-request)
- [ ] I've read and followed all steps in the [Making a pull request](https://github.com/bellingcat/vk-url-scraper/blob/main/CONTRIBUTING.md#making-a-pull-request)
section of the `CONTRIBUTING` docs.
- [ ] I've updated or added any relevant docstrings following the syntax described in the
[Writing docstrings](https://github.com/allenai/beaker-py/blob/main/CONTRIBUTING.md#writing-docstrings) section of the `CONTRIBUTING` docs.
[Writing docstrings](https://github.com/bellingcat/vk-url-scraper/blob/main/CONTRIBUTING.md#writing-docstrings) section of the `CONTRIBUTING` docs.
- [ ] If this PR fixes a bug, I've added a test that will fail without my fix.
- [ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

View File

@@ -88,7 +88,7 @@ jobs:
if: always()
run: |
. .venv/bin/activate
pip uninstall -y my-package
pip uninstall -y vk-url-scraper
release:
name: Release

View File

@@ -9,7 +9,7 @@ on:
branches:
- main
paths:
- 'my_package/**'
- 'vk_url_scraper/**'
jobs:
changelog:

View File

@@ -1,51 +0,0 @@
name: Setup
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on:
pull_request:
branches:
- main
push:
branches:
- main
jobs:
test_personalize:
name: Personalize
runs-on: [ubuntu-latest]
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: '3.7'
- name: Install prerequisites
run: |
pip install -r setup-requirements.txt
- name: Run personalize script
run: |
python scripts/personalize.py --github-org epwalsh --github-repo new-repo --package-name new-package --yes
- name: Verify changes
shell: bash
run: |
set -eo pipefail
# Check that 'new-package' replaced 'my-package' in some files.
grep -q 'new-package' setup.py .github/workflows/main.yml CONTRIBUTING.md
# Check that the new repo URL replaced the old one in some files.
grep -q 'https://github.com/epwalsh/new-repo' setup.py CONTRIBUTING.md
# Double check that there are no lingering mentions of old names.
for pattern in 'my[-_]package' 'https://github.com/allenai/python-package-template'; do
if find . -type f -not -path './.git/*' | xargs grep "$pattern"; then
echo "Found ${pattern} where it shouldn't be!"
exit 1
fi
done
echo "All good!"