From ede2f1efaa44f6c1afe337809b8800f6f0c8f7bd Mon Sep 17 00:00:00 2001 From: Lachlan Kermode Date: Wed, 26 Dec 2018 12:33:08 +0100 Subject: [PATCH] don't draw lines for unlocated events in narrative mode --- src/components/MapNarratives.jsx | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/components/MapNarratives.jsx b/src/components/MapNarratives.jsx index 8835fec..2c9d777 100644 --- a/src/components/MapNarratives.jsx +++ b/src/components/MapNarratives.jsx @@ -39,10 +39,18 @@ class MapNarratives extends React.Component { return 1; } + hasNoLocation(step) { + return (step.latitude === '' || step.longitude === '') + } + renderNarrativeStep(allSteps, step, idx, n) { const { x, y } = this.projectPoint([step.latitude, step.longitude]); - const step2 = allSteps[idx + 1]; + + // don't draw if one of the steps has no location + if (this.hasNoLocation(step) || this.hasNoLocation(step2)) + return null + const p2 = this.projectPoint([step2.latitude, step2.longitude]); return (