From ea1dc45ea791a493f34508277c86cf49079e65d3 Mon Sep 17 00:00:00 2001
From: Lachlan Kermode <lachiekermode@gmail.com>
Date: Thu, 3 Mar 2022 11:59:41 -0500
Subject: [PATCH] Fix warnings

---
 src/components/atoms/ColoredMarkers.js       |  1 +
 src/components/controls/CardStack.js         | 21 +++++++++++---------
 src/components/space/carto/atoms/Clusters.js |  3 ++-
 src/components/space/carto/atoms/Events.js   |  3 ++-
 src/components/time/atoms/Events.js          |  3 +++
 5 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/src/components/atoms/ColoredMarkers.js b/src/components/atoms/ColoredMarkers.js
index bcd738f..8cd0b6e 100644
--- a/src/components/atoms/ColoredMarkers.js
+++ b/src/components/atoms/ColoredMarkers.js
@@ -39,6 +39,7 @@ function ColoredMarkers({ radius, colorPercentMap, styles, className }) {
 
         return (
           <path
+            key={`arc_${idx}`}
             className={className}
             id={`arc_${idx}`}
             d={arc}
diff --git a/src/components/controls/CardStack.js b/src/components/controls/CardStack.js
index b8c8a86..3c6c841 100644
--- a/src/components/controls/CardStack.js
+++ b/src/components/controls/CardStack.js
@@ -1,8 +1,8 @@
 import React from "react";
 import { connect } from "react-redux";
 import {
-  Card,
   generateCardLayout,
+  Card,
 } from "@forensic-architecture/design-system/dist/react";
 
 import * as selectors from "../../selectors";
@@ -28,8 +28,8 @@ class CardStack extends React.Component {
   scrollToCard() {
     const duration = 500;
     const element = this.refCardStack.current;
-    const cardScroll = this.refs[this.props.narrative.current].current
-      .offsetTop;
+    const cardScroll =
+      this.refs[this.props.narrative.current].current.offsetTop;
 
     const start = element.scrollTop;
     const change = cardScroll - start;
@@ -70,15 +70,18 @@ class CardStack extends React.Component {
       const thisRef = React.createRef();
       this.refs[idx] = thisRef;
 
+      const content = generateTemplate({
+        event,
+        colors: this.props.colors,
+        coloringSet: this.props.coloringSet,
+        getFilterIdxFromColorSet,
+      });
+
       return (
         <Card
           ref={thisRef}
-          content={generateTemplate({
-            event,
-            colors: this.props.colors,
-            coloringSet: this.props.coloringSet,
-            getFilterIdxFromColorSet,
-          })}
+          key={idx}
+          content={content}
           language={this.props.language}
           isLoading={this.props.isLoading}
           isSelected={selections[idx]}
diff --git a/src/components/space/carto/atoms/Clusters.js b/src/components/space/carto/atoms/Clusters.js
index 49fcdbb..f652e64 100644
--- a/src/components/space/carto/atoms/Clusters.js
+++ b/src/components/space/carto/atoms/Clusters.js
@@ -133,11 +133,12 @@ function ClusterEvents({
       <svg>
         <g className="cluster-locations">
           {isRadial ? <DefsClusters /> : null}
-          {clusters.map((c) => {
+          {clusters.map((c, idx) => {
             const pointCount = c.properties.point_count;
             const clusterSize = calcClusterSize(pointCount, totalPoints);
             return (
               <Cluster
+                key={idx}
                 onClick={onSelect}
                 getClusterChildren={getClusterChildren}
                 coloringSet={coloringSet}
diff --git a/src/components/space/carto/atoms/Events.js b/src/components/space/carto/atoms/Events.js
index 0b14cf4..a51f9ef 100644
--- a/src/components/space/carto/atoms/Events.js
+++ b/src/components/space/carto/atoms/Events.js
@@ -2,6 +2,7 @@ import React from "react";
 import { Portal } from "react-portal";
 import colors from "../../../../common/global";
 import ColoredMarkers from "../../../atoms/ColoredMarkers";
+import hash from "object-hash";
 import {
   calcOpacity,
   calculateColorPercentages,
@@ -102,7 +103,7 @@ function MapEvents({
     }, false);
 
     return (
-      <svg>
+      <svg key={hash(location)}>
         <g
           className={`location-event ${narrative ? "no-hover" : ""}`}
           transform={`translate(${x}, ${y})`}
diff --git a/src/components/time/atoms/Events.js b/src/components/time/atoms/Events.js
index f0fb7a6..077dae4 100644
--- a/src/components/time/atoms/Events.js
+++ b/src/components/time/atoms/Events.js
@@ -6,6 +6,7 @@ import DatetimeTriangle from "./DatetimeTriangle";
 import DatetimePentagon from "./DatetimePentagon";
 import Project from "./Project";
 import ColoredMarkers from "../../atoms/ColoredMarkers";
+import hash from "object-hash";
 import {
   calcOpacity,
   getEventCategories,
@@ -23,6 +24,7 @@ function renderDot(event, styles, props) {
   );
   return (
     <g
+      key={hash(event)}
       className="timeline-event"
       onClick={props.onSelect}
       transform={`translate(${props.x}, ${props.y})`}
@@ -232,6 +234,7 @@ const TimelineEvents = ({
         <>
           {Object.values(projects).map((project) => (
             <Project
+              key={project.id}
               {...project}
               eventRadius={eventRadius}
               onClick={() => console.log(project)}