From d38520ea3d79ca1071064252e01a0da5eb4a3263 Mon Sep 17 00:00:00 2001 From: Lachlan Kermode Date: Tue, 27 Oct 2020 15:34:46 +0100 Subject: [PATCH] fix corner case for toggling parents off --- src/components/Toolbar/Layout.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/Toolbar/Layout.js b/src/components/Toolbar/Layout.js index 3b7aa42..7f866f3 100644 --- a/src/components/Toolbar/Layout.js +++ b/src/components/Toolbar/Layout.js @@ -9,7 +9,7 @@ import FilterListPanel from './FilterListPanel' import CategoriesListPanel from './CategoriesListPanel' import BottomActions from './BottomActions' import copy from '../../common/data/copy.json' -import { trimAndEllipse, getImmediateFilterParent, getFilterSiblings } from '../../common/utilities.js' +import { trimAndEllipse, getImmediateFilterParent, getFilterSiblings, getFilterParents } from '../../common/utilities.js' class Toolbar extends React.Component { constructor (props) { @@ -59,7 +59,8 @@ class Toolbar extends React.Component { } if (siblingsOff && isTurningOff) { - matchingKeys.push(parent) + const grandparentsOn = getFilterParents(filters, key).filter(filt => activeFilters.includes(filt)) + matchingKeys = matchingKeys.concat(grandparentsOn) } } }