bellingcat/ukraine-timemap
1
0
Fork 0
mirror of https://github.com/bellingcat/ukraine-timemap.git synced 2026-06-12 13:28:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

Only rerender NarrativeCard if step has changed

Browse Source
This commit is contained in:
Franc Camps-Febrer
2018-12-14 17:21:36 +01:00
committed by Lachlan Kermode
parent 4423e792ec
commit 40ac0eb120
4 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/NarrativeCard.js
View File

@@ -23,8 +23,13 @@ class NarrativeCard extends React.Component {
}
}
componentDidUpdate() {
if (this.props.narrative !== null) {
componentDidMount() {
const step = this.props.narrative.steps[this.state.step];
this.props.onSelect([step]);
}
componentDidUpdate(prevProps, prevState) {
if (prevProps.narrative === this.props.narrative && this.state.step !== prevState.step) {
const step = this.props.narrative.steps[this.state.step];
this.props.onSelect([step]);
}
@@ -42,7 +47,7 @@ class NarrativeCard extends React.Component {
}
render() {
if (this.props.narrative !== null && this.props.narrative.steps[this.state.step]) {
if (this.props.narrative.steps[this.state.step]) {
const steps = this.props.narrative.steps;
const step = steps[this.state.step];