Add linting and cleaned up obvious suggestions

src/actions/index.js

@@ -1,16 +1,15 @@
+/* global fetch, alert */
 import { urlFromEnv } from '../js/utilities'
 
-const EVENT_DATA_URL = urlFromEnv('EVENT_EXT');
-const CATEGORY_URL = urlFromEnv('CATEGORY_EXT');
-const TAGS_URL = urlFromEnv('TAGS_EXT');
-const SOURCES_URL = urlFromEnv('SOURCES_EXT');
-const NARRATIVE_URL = urlFromEnv('NARRATIVE_EXT');
-const SITES_URL = urlFromEnv('SITES_EXT');
-const eventUrlMap = (event) => `${process.env.SERVER_ROOT}${process.env.EVENT_DESC_ROOT}/${(event.id) ? event.id : event}`;
+const EVENT_DATA_URL = urlFromEnv('EVENT_EXT')
+const CATEGORY_URL = urlFromEnv('CATEGORY_EXT')
+const TAGS_URL = urlFromEnv('TAGS_EXT')
+const SOURCES_URL = urlFromEnv('SOURCES_EXT')
+const NARRATIVE_URL = urlFromEnv('NARRATIVE_EXT')
+const SITES_URL = urlFromEnv('SITES_EXT')
 
 const domainMsg = (domainType) => `Something went wrong fetching ${domainType}. Check the URL or try disabling them in the config file.`
 
-
 export function fetchDomain () {
   let notifications = []
 
@@ -24,7 +23,6 @@ export function fetchDomain () {
 
   return dispatch => {
     dispatch(toggleFetchingDomain())
-    const promises = []
 
     const eventPromise = fetch(EVENT_DATA_URL)
       .then(response => response.json())
@@ -96,27 +94,26 @@ export function fetchDomain () {
         // TODO: handle this appropriately in React hierarchy
         alert(err.message)
       })
-  };
+  }
 }
 
 export const FETCH_ERROR = 'FETCH_ERROR'
-export function fetchError(message) {
+export function fetchError (message) {
   return {
     type: FETCH_ERROR,
-    message,
+    message
   }
 }
 
 export const UPDATE_DOMAIN = 'UPDATE_DOMAIN'
-export function updateDomain(domain) {
+export function updateDomain (domain) {
   return {
     type: UPDATE_DOMAIN,
     domain
   }
 }
 
-
-export function fetchSource(source) {
+export function fetchSource (source) {
   return dispatch => {
     if (!SOURCES_URL) {
       dispatch(fetchSourceError('No source extension specified.'))
@@ -135,14 +132,12 @@ export function fetchSource(source) {
           dispatch(fetchSourceError(err.message))
           dispatch(toggleFetchingSources())
         })
-
     }
-
   }
 }
 
 export const UPDATE_HIGHLIGHTED = 'UPDATE_HIGHLIGHTED'
-export function updateHighlighted(highlighted) {
+export function updateHighlighted (highlighted) {
   return {
     type: UPDATE_HIGHLIGHTED,
     highlighted: highlighted
@@ -150,7 +145,7 @@ export function updateHighlighted(highlighted) {
 }
 
 export const UPDATE_SELECTED = 'UPDATE_SELECTED'
-export function updateSelected(selected) {
+export function updateSelected (selected) {
   return {
     type: UPDATE_SELECTED,
     selected: selected
@@ -158,7 +153,7 @@ export function updateSelected(selected) {
 }
 
 export const UPDATE_DISTRICT = 'UPDATE_DISTRICT'
-export function updateDistrict(district) {
+export function updateDistrict (district) {
   return {
     type: UPDATE_DISTRICT,
     district
@@ -166,7 +161,7 @@ export function updateDistrict(district) {
 }
 
 export const UPDATE_TAGFILTERS = 'UPDATE_TAGFILTERS'
-export function updateTagFilters(tag) {
+export function updateTagFilters (tag) {
   return {
     type: UPDATE_TAGFILTERS,
     tag
@@ -174,52 +169,52 @@ export function updateTagFilters(tag) {
 }
 
 export const UPDATE_CATEGORYFILTERS = 'UPDATE_CATEGORYFILTERS'
-export function updateCategoryFilters(category) {
+export function updateCategoryFilters (category) {
   return {
     type: UPDATE_CATEGORYFILTERS,
     category
   }
 }
 
-export const UPDATE_TIMERANGE = 'UPDATE_TIMERANGE';
-export function updateTimeRange(timerange) {
+export const UPDATE_TIMERANGE = 'UPDATE_TIMERANGE'
+export function updateTimeRange (timerange) {
   return {
     type: UPDATE_TIMERANGE,
     timerange
   }
 }
 
-export const UPDATE_NARRATIVE = 'UPDATE_NARRATIVE';
-export function updateNarrative(narrative) {
+export const UPDATE_NARRATIVE = 'UPDATE_NARRATIVE'
+export function updateNarrative (narrative) {
   return {
     type: UPDATE_NARRATIVE,
     narrative
   }
 }
 
-export const INCREMENT_NARRATIVE_CURRENT = 'INCREMENT_NARRATIVE_CURRENT';
-export function incrementNarrativeCurrent() {
+export const INCREMENT_NARRATIVE_CURRENT = 'INCREMENT_NARRATIVE_CURRENT'
+export function incrementNarrativeCurrent () {
   return {
     type: INCREMENT_NARRATIVE_CURRENT
   }
 }
 
-export const DECREMENT_NARRATIVE_CURRENT = 'DECREMENT_NARRATIVE_CURRENT';
-export function decrementNarrativeCurrent() {
+export const DECREMENT_NARRATIVE_CURRENT = 'DECREMENT_NARRATIVE_CURRENT'
+export function decrementNarrativeCurrent () {
   return {
     type: DECREMENT_NARRATIVE_CURRENT
   }
 }
 
 export const RESET_ALLFILTERS = 'RESET_ALLFILTERS'
-export function resetAllFilters() {
+export function resetAllFilters () {
   return {
     type: RESET_ALLFILTERS
   }
 }
 
-export const UPDATE_SOURCE = "UPDATE_SOURCE"
-export function updateSource(source) {
+export const UPDATE_SOURCE = 'UPDATE_SOURCE'
+export function updateSource (source) {
   return {
     type: UPDATE_SOURCE,
     source
@@ -229,65 +224,65 @@ export function updateSource(source) {
 // UI
 
 export const TOGGLE_SITES = 'TOGGLE_SITES'
-export function toggleSites() {
+export function toggleSites () {
   return {
     type: TOGGLE_SITES
   }
 }
 
 export const TOGGLE_FETCHING_DOMAIN = 'TOGGLE_FETCHING_DOMAIN'
-export function toggleFetchingDomain() {
+export function toggleFetchingDomain () {
   return {
     type: TOGGLE_FETCHING_DOMAIN
   }
 }
 
 export const TOGGLE_FETCHING_SOURCES = 'TOGGLE_FETCHING_SOURCES'
-export function toggleFetchingSources() {
+export function toggleFetchingSources () {
   return {
     type: TOGGLE_FETCHING_SOURCES
   }
 }
 
-export const TOGGLE_LANGUAGE = 'TOGGLE_LANGUAGE';
-export function toggleLanguage(language) {
+export const TOGGLE_LANGUAGE = 'TOGGLE_LANGUAGE'
+export function toggleLanguage (language) {
   return {
     type: TOGGLE_LANGUAGE,
-    language,
+    language
   }
 }
 
-export const CLOSE_TOOLBAR = 'CLOSE_TOOLBAR';
-export function closeToolbar() {
+export const CLOSE_TOOLBAR = 'CLOSE_TOOLBAR'
+export function closeToolbar () {
   return {
     type: CLOSE_TOOLBAR
   }
 }
 
-export const TOGGLE_INFOPOPUP = 'TOGGLE_INFOPOPUP';
-export function toggleInfoPopup() {
+export const TOGGLE_INFOPOPUP = 'TOGGLE_INFOPOPUP'
+export function toggleInfoPopup () {
   return {
     type: TOGGLE_INFOPOPUP
   }
 }
 
-export const TOGGLE_MAPVIEW = 'TOGGLE_MAPVIEW';
- export function toggleMapView(layer) {
-   return {
-     type: TOGGLE_MAPVIEW,
-     layer
-   }
- }
+export const TOGGLE_MAPVIEW = 'TOGGLE_MAPVIEW'
+export function toggleMapView (layer) {
+  return {
+    type: TOGGLE_MAPVIEW,
+    layer
+  }
+}
 
 export const TOGGLE_NOTIFICATIONS = 'TOGGLE_NOTIFICATIONS'
-export function toggleNotifications() {
+export function toggleNotifications () {
   return {
     type: TOGGLE_NOTIFICATIONS
   }
 }
 
 export const MARK_NOTIFICATIONS_READ = 'MARK_NOTIFICATIONS_READ'
-export function markNotificationsRead() {
+export function markNotificationsRead () {
   return {
     type: MARK_NOTIFICATIONS_READ
   }
@@ -296,7 +291,7 @@ export function markNotificationsRead() {
 // ERRORS
 
 export const FETCH_SOURCE_ERROR = 'FETCH_SOURCE_ERROR'
-export function fetchSourceError(msg) {
+export function fetchSourceError (msg) {
   return {
     type: FETCH_SOURCE_ERROR,
     msg