From be03a3983a314320eb8ef5296881516e6cb5f7a9 Mon Sep 17 00:00:00 2001 From: Ebrahem Farooqui Date: Mon, 22 Feb 2021 09:47:05 -0800 Subject: [PATCH 1/3] Adding branch to checkout Adding the correct branch to checkout with for workflow --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 591401a..0aa8189 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,6 +10,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + with: + ref: ${GITHUB_REF##*/} - uses: actions/setup-node@v2-beta with: node-version: '12' From 3eebf811fbf89f0a555fd4641aaa6171fc700369 Mon Sep 17 00:00:00 2001 From: Ebrahem Farooqui Date: Mon, 22 Feb 2021 09:50:46 -0800 Subject: [PATCH 2/3] Incorrect syntax for unpacking head ref --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0aa8189..da22ccd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ jobs: steps: - uses: actions/checkout@v2 with: - ref: ${GITHUB_REF##*/} + ref: ${{ github.head_ref }} - uses: actions/setup-node@v2-beta with: node-version: '12' From 679407f4213ca06b0a3059dbc20e8af4f3b1de7c Mon Sep 17 00:00:00 2001 From: Ebrahem Farooqui Date: Mon, 1 Mar 2021 16:05:16 -0800 Subject: [PATCH 3/3] adding env vars for test and lint --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index da22ccd..df6d743 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,5 +18,8 @@ jobs: - run: npm install - run: npm test + env: + CI: true - run: npm run lint - + env: + CI: true