refactor

storages/base_storage.py

@@ -23,23 +23,7 @@ class Storage(ABC):
         with open(filename, 'rb') as f:
             self.uploadf(f, key, **kwargs)
 
-    def update_properties(self, **kwargs):
-        """
-        method used to update general properties that some children may use 
-        and others not, but that all can call
-        """
-        for k, v in kwargs.items():
-            if k in self._get_allowed_properties():
-                setattr(self, k, v)
-            else:
-                logger.warning(f'[{self.__class__.__name__}] does not accept dynamic property "{k}"')
-
-    def _get_allowed_properties(self):
-        """
-        child classes should specify which properties they allow to be set
-        """
-        return set(["subfolder"])
-
+    #TODO: is this really necessary if only use os.path operations
     def _clean_path(self, folder, default="", add_forward_slash=True):
         if folder is None or type(folder) != str or len(folder.strip()) == 0:
             return default