From f3f6b928172fe597c772e2c677a3f3d118f02bef Mon Sep 17 00:00:00 2001
From: Patrick Robertson <robertson.patrick@gmail.com>
Date: Mon, 10 Feb 2025 12:43:21 +0000
Subject: [PATCH] Implementation test cleanup

---
 tests/test_implementation.py | 45 ++++++++++++++++++++++++++++--------
 1 file changed, 36 insertions(+), 9 deletions(-)

diff --git a/tests/test_implementation.py b/tests/test_implementation.py
index 82d5d0f..7e33651 100644
--- a/tests/test_implementation.py
+++ b/tests/test_implementation.py
@@ -3,33 +3,60 @@ import pytest
 
 from auto_archiver.__main__ import main
 
+
 @pytest.fixture
-def orchestration_file(tmp_path):
+def orchestration_file_path(tmp_path):
     return (tmp_path / "example_orch.yaml").as_posix()
 
 @pytest.fixture
-def autoarchiver(tmp_path, monkeypatch):
+def orchestration_file(orchestration_file_path):
+    def _orchestration_file(content=''):
+        with open(orchestration_file_path, "w") as f:
+            f.write(content)
+        return orchestration_file_path
+    
+    return _orchestration_file
+
+@pytest.fixture
+def autoarchiver(tmp_path, monkeypatch, request):
+    def _autoarchiver(args=[]):
+
+        def cleanup():
+            from loguru import logger
+            if not logger._core.handlers.get(0):
+                logger._core.handlers_count = 0
+                logger.add(sys.stderr)
+
+        request.addfinalizer(cleanup)
 
-    def _autoarchiver(args=["--config", "example_orch.yaml"]):
         # change dir to tmp_path
         monkeypatch.chdir(tmp_path)
         with monkeypatch.context() as m:
             m.setattr(sys, "argv", ["auto-archiver"] + args)
             return main()
-    
+
     return _autoarchiver
 
 
 def test_run_auto_archiver_no_args(caplog, autoarchiver):
     with pytest.raises(SystemExit):
-        autoarchiver([])
+        autoarchiver()
 
     assert "provide at least one URL via the command line, or set up an alternative feeder" in caplog.text
 
-
-def test_run_auto_archiver_invalid_file(caplog, autoarchiver, monkeypatch):
+def test_run_auto_archiver_invalid_file(caplog, autoarchiver):
     # exec 'auto-archiver' on the command lin
     with pytest.raises(SystemExit):
-        autoarchiver()
+        autoarchiver(["--config", "nonexistent_file.yaml"])
 
-    assert "Make sure the file exists and try again, or run without th" in caplog.text
\ No newline at end of file
+    assert "Make sure the file exists and try again, or run without th" in caplog.text
+
+def test_run_auto_archiver_empty_file(caplog, autoarchiver, orchestration_file):
+    # create a valid (empty) orchestration file
+    path = orchestration_file(content="")
+    # exec 'auto-archiver' on the command lin
+    with pytest.raises(SystemExit):
+        autoarchiver(["--config", path])
+
+    # should treat an empty file as if there is no file at all
+    assert " No URLs provided. Please provide at least one URL via the com" in caplog.text