From aac16fa8c2946e75e63cc861649bcdb675fbc860 Mon Sep 17 00:00:00 2001 From: msramalho <19508417+msramalho@users.noreply.github.com> Date: Mon, 9 Jan 2023 22:24:44 +0000 Subject: [PATCH] minor comments --- src/databases/gsheet_db.py | 1 + src/steps/step.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/databases/gsheet_db.py b/src/databases/gsheet_db.py index a5e462f..ba3785a 100644 --- a/src/databases/gsheet_db.py +++ b/src/databases/gsheet_db.py @@ -91,4 +91,5 @@ class GsheetsDb(Database): def _retrieve_gsheet(self, item: Metadata) -> Tuple[GWorksheet, int]: gw: GWorksheet = item.get("gsheet").get("worksheet") row: int = item.get("gsheet").get("row") + #TODO: to make gsheet_db less coupled with gsheet_feeder's "gsheet" parameter, this method could 1st try to fetch "gsheet" from item and, if missing, manage its own singleton - not needed for now return gw, row diff --git a/src/steps/step.py b/src/steps/step.py index b512af7..a8bad38 100644 --- a/src/steps/step.py +++ b/src/steps/step.py @@ -28,4 +28,4 @@ class Step(ABC): for sub in child.__subclasses__(): if sub.name == name: return sub(config) - raise ClassFoundException(f"Unable to initialize STEP with {name=}") + raise ClassFoundException(f"Unable to initialize STEP with {name=}, check your configuration file/step names.")