From 2e25e59fa6dac4c742caa02eebfac650044d6fc1 Mon Sep 17 00:00:00 2001 From: Patrick Robertson Date: Thu, 13 Mar 2025 16:07:49 +0000 Subject: [PATCH] Fix unit tests - make caplog checks more robust, having added a new logger/debug call --- tests/extractors/test_tiktok_tikwm_extractor.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/extractors/test_tiktok_tikwm_extractor.py b/tests/extractors/test_tiktok_tikwm_extractor.py index 51bb57a..3d0c926 100644 --- a/tests/extractors/test_tiktok_tikwm_extractor.py +++ b/tests/extractors/test_tiktok_tikwm_extractor.py @@ -37,9 +37,8 @@ class TestTiktokTikwmExtractor(TestExtractorBase): assert self.extractor.download(make_item(self.VALID_EXAMPLE_URL)) == False mock_get.assert_called_once() mock_get.return_value.json.assert_called_once() - assert len(caplog.records) == 2 # first message is just the 'Skipping using ytdlp to download files for TikTok' message - assert "failed to parse JSON response from tikwm.com for url='https://www.tiktok.com/@example/video/1234'" in caplog.records[1].message + assert "failed to parse JSON response from tikwm.com for url='https://www.tiktok.com/@example/video/1234'" in caplog.text mock_get.return_value.json.side_effect = Exception with caplog.at_level('ERROR'): @@ -47,8 +46,7 @@ class TestTiktokTikwmExtractor(TestExtractorBase): mock_get.assert_called() assert mock_get.call_count == 2 assert mock_get.return_value.json.call_count == 2 - assert len(caplog.records) == 2 - assert "failed to parse JSON response from tikwm.com for url='https://www.tiktok.com/@example/video/1234'" in caplog.records[1].message + assert "failed to parse JSON response from tikwm.com for url='https://www.tiktok.com/@example/video/1234'" in caplog.text @pytest.mark.parametrize("response", [ ({"msg": "failure"}), @@ -61,7 +59,7 @@ class TestTiktokTikwmExtractor(TestExtractorBase): assert self.extractor.download(make_item(self.VALID_EXAMPLE_URL)) == False mock_get.assert_called_once() mock_get.return_value.json.assert_called_once() - assert "failed to get a valid response from tikwm.com" in caplog.records[1].message + assert "failed to get a valid response from tikwm.com" in caplog.text @pytest.mark.parametrize("response,has_vid", [ ({"data": {"id": 123}}, False),