refactoring filenumber into subfolder

storages/base_storage.py

@@ -1,5 +1,6 @@
 from loguru import logger
 from abc import ABC, abstractmethod
+from pathlib import Path
 
 
 class Storage(ABC):
@@ -19,3 +20,25 @@ class Storage(ABC):
         logger.debug(f'[{self.__class__.__name__}] uploading file {filename} with key {key}')
         with open(filename, 'rb') as f:
             self.uploadf(f, key, **kwargs)
+
+    def update_properties(self, **kwargs):
+        """
+        method used to update general properties that some children may use 
+        and others not, but that all can call
+        """
+        for k, v in kwargs.items():
+            if k in self.get_allowed_properties():
+                setattr(self, k, v)
+            else:
+                logger.warning(f'[{self.__class__.__name__}] does not accept dynamic property "{k}"')
+
+    def get_allowed_properties(self):
+        """
+        child classes should specify which properties they allow to be set
+        """
+        return set(["subfolder"])
+
+    def clean_path(self, folder, default="", add_forward_slash=True):
+        if folder is None or type(folder) != str or len(folder.strip()) == 0:
+            return default
+        return str(Path(folder)) + ("/" if add_forward_slash else "")