From 0ec5451f666edb2f8492e05fc676ec9de6770d07 Mon Sep 17 00:00:00 2001 From: Patrick Robertson Date: Mon, 17 Mar 2025 09:34:33 +0000 Subject: [PATCH] Nicer error log when no URLs provided for CLI feeder - don't need the stacktrace --- src/auto_archiver/core/orchestrator.py | 3 ++- src/auto_archiver/modules/cli_feeder/cli_feeder.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/auto_archiver/core/orchestrator.py b/src/auto_archiver/core/orchestrator.py index 672994a..d8f3e87 100644 --- a/src/auto_archiver/core/orchestrator.py +++ b/src/auto_archiver/core/orchestrator.py @@ -377,7 +377,8 @@ Here's how that would look: \n\nsteps:\n extractors:\n - [your_extractor_name_ try: loaded_module: BaseModule = self.module_factory.get_module(module, self.config) except (KeyboardInterrupt, Exception) as e: - logger.error(f"Error during setup of modules: {e}\n{traceback.format_exc()}") + if not isinstance(e, KeyboardInterrupt) and not isinstance(e, SetupError): + logger.error(f"Error during setup of modules: {e}\n{traceback.format_exc()}") if loaded_module and module_type == "extractor": loaded_module.cleanup() raise e diff --git a/src/auto_archiver/modules/cli_feeder/cli_feeder.py b/src/auto_archiver/modules/cli_feeder/cli_feeder.py index 4367bbc..5935466 100644 --- a/src/auto_archiver/modules/cli_feeder/cli_feeder.py +++ b/src/auto_archiver/modules/cli_feeder/cli_feeder.py @@ -2,13 +2,14 @@ from loguru import logger from auto_archiver.core.feeder import Feeder from auto_archiver.core.metadata import Metadata +from auto_archiver.core.consts import SetupError class CLIFeeder(Feeder): def setup(self) -> None: self.urls = self.config["urls"] if not self.urls: - raise ValueError( + raise SetupError( "No URLs provided. Please provide at least one URL via the command line, or set up an alternative feeder. Use --help for more information." )