refactors settings and adds security tests

src/db/crud.py

@@ -5,13 +5,13 @@ from loguru import logger
 from datetime import datetime, timedelta
 
 from web.security import ALLOW_ANY_EMAIL
-from shared.settings import Settings
+from shared.settings import get_settings
 from . import models, schemas
 import yaml
 
 DOMAIN_GROUPS = {}
 DOMAIN_GROUPS_LOADED = False
-DATABASE_QUERY_LIMIT = Settings().DATABASE_QUERY_LIMIT
+DATABASE_QUERY_LIMIT = get_settings().DATABASE_QUERY_LIMIT
 
 # --------------- TASK = Archive
 
@@ -152,7 +152,7 @@ def upsert_user_groups(db: Session):
     along with new participation of users in groups
     """
     logger.debug("Updating user-groups configuration.")
-    filename = Settings().USER_GROUPS_FILENAME
+    filename = get_settings().USER_GROUPS_FILENAME
 
     # read yaml safely
     try:

src/db/database.py

@@ -1,11 +1,9 @@
 from sqlalchemy import Engine, create_engine, event
-from sqlalchemy.orm import sessionmaker, declarative_base
-from shared.settings import Settings
+from sqlalchemy.orm import sessionmaker
+from shared.settings import get_settings
 from contextlib import contextmanager
 
 
-settings = Settings()
-
 def make_engine(database_url: str):
     engine = create_engine(database_url, connect_args={"check_same_thread": False})
 
@@ -25,7 +23,7 @@ def make_session_local(engine: Engine):
 
 @contextmanager
 def get_db():
-    session = make_session_local(make_engine(settings.DATABASE_PATH))()
+    session = make_session_local(make_engine(get_settings().DATABASE_PATH))()
     try: yield session
     finally: session.close()