diff --git a/app/shared/db/worker_crud.py b/app/shared/db/worker_crud.py index 93962b9..6766786 100644 --- a/app/shared/db/worker_crud.py +++ b/app/shared/db/worker_crud.py @@ -55,7 +55,7 @@ def create_task(db: Session, task: schemas.ArchiveCreate, tags: list[models.Tag] def store_archived_url(db: Session, archive: schemas.ArchiveCreate) -> models.Archive: # create and load user, tags, if needed create_or_get_user(db, archive.author_id) - db_tags = [create_tag(db, tag) for tag in archive.tags] + db_tags = [create_tag(db, tag) for tag in (archive.tags or [])] # insert everything db_task = create_task(db, task=archive, tags=db_tags, urls=archive.urls) return db_task diff --git a/app/tests/web/endpoints/test_default.py b/app/tests/web/endpoints/test_default.py index 1e0e49f..b4ed7a5 100644 --- a/app/tests/web/endpoints/test_default.py +++ b/app/tests/web/endpoints/test_default.py @@ -1,4 +1,4 @@ -from unittest.mock import AsyncMock, MagicMock, patch +from unittest.mock import MagicMock from fastapi.testclient import TestClient import pytest from app.web.config import VERSION diff --git a/app/web/middleware.py b/app/web/middleware.py index aa5c077..227a620 100644 --- a/app/web/middleware.py +++ b/app/web/middleware.py @@ -8,6 +8,8 @@ from app.web.utils.metrics import EXCEPTION_COUNTER async def logging_middleware(request: Request, call_next): try: response = await call_next(request) + #TODO: use Origin to have summary prometheus metrics on where requests come from + # origin = request.headers.get("origin") logger.info(f"{request.client.host}:{request.client.port} {request.method} {request.url._url} - HTTP {response.status_code}") return response except Exception as e: